Skip to main content

Search and Top Navigation

Ticket #3648: dialog-container-r1174.patch


File dialog-container-r1174.patch, 4.9 KB (added by scottgonzalez, December 18, 2008 10:14PM UTC)

Removal of container div and autoResize option

Index: /Users/sgonzale/Documents/workspace/jQuery UI/ui/ui.dialog.js
===================================================================
--- /Users/sgonzale/Documents/workspace/jQuery UI/ui/ui.dialog.js	(revision 1174)
+++ /Users/sgonzale/Documents/workspace/jQuery UI/ui/ui.dialog.js	(working copy)
@@ -35,9 +35,42 @@
 
 		var self = this,
 			options = this.options,
-
+			
+			title = options.title || ' ',
+			titleId = $.ui.dialog.getTitleId(this.element),
+			
+			uiDialog = (this.uiDialog = $('
')) + .hide() + .addClass( + 'ui-dialog ' + + 'ui-widget ' + + 'ui-widget-content ' + + 'ui-corner-all ' + + options.dialogClass + ) + .css({ + position: 'absolute', + width: options.width, + height: options.height, + overflow: 'hidden', + zIndex: options.zIndex + }) + // setting tabIndex makes the div focusable + // setting outline to 0 prevents a border on focus in Mozilla + .attr('tabIndex', -1).css('outline', 0).keydown(function(ev) { + (options.closeOnEscape && ev.keyCode + && ev.keyCode == $.ui.keyCode.ESCAPE && self.close()); + }) + .attr({ + role: 'dialog', + 'aria-labelledby': titleId + }) + .mouseup(function() { + self.moveToTop(); + }) + .appendTo(document.body), + uiDialogContent = this.element - .appendTo(document.body) .removeAttr('title') .addClass( 'ui-dialog-content ' + @@ -42,16 +75,7 @@ .addClass( 'ui-dialog-content ' + 'ui-widget-content') - .wrap('
') - .wrap('
'), - - uiDialogContainer = (this.uiDialogContainer = uiDialogContent.parent()) - .addClass('ui-dialog-container') - .css({ - position: 'relative', - width: '100%', - height: '100%' - }), + .appendTo(uiDialog), uiDialogTitlebar = (this.uiDialogTitlebar = $('
')) .addClass( @@ -63,7 +87,7 @@ .mousedown(function() { self.moveToTop(); }) - .prependTo(uiDialogContainer), + .prependTo(uiDialog), uiDialogTitlebarClose = $('') .addClass( @@ -96,8 +120,6 @@ .text(options.closeText) .appendTo(uiDialogTitlebarClose), - title = options.title || ' ', - titleId = $.ui.dialog.getTitleId(this.element), uiDialogTitle = $('') .addClass('ui-dialog-title') .attr('id', titleId) @@ -104,36 +126,6 @@ .html(title) .prependTo(uiDialogTitlebar), - uiDialog = (this.uiDialog = uiDialogContainer.parent()) - .hide() - .addClass( - 'ui-dialog ' + - 'ui-widget ' + - 'ui-widget-content ' + - 'ui-corner-all' - ) - .addClass(options.dialogClass) - .css({ - position: 'absolute', - width: options.width, - height: options.height, - overflow: 'hidden', - zIndex: options.zIndex - }) - // setting tabIndex makes the div focusable - // setting outline to 0 prevents a border on focus in Mozilla - .attr('tabIndex', -1).css('outline', 0).keydown(function(ev) { - (options.closeOnEscape && ev.keyCode - && ev.keyCode == $.ui.keyCode.ESCAPE && self.close()); - }) - .attr({ - role: 'dialog', - 'aria-labelledby': titleId - }) - .mouseup(function() { - self.moveToTop(); - }), - uiDialogButtonPane = (this.uiDialogButtonPane = $('
')) .addClass( 'ui-dialog-buttonpane ' + @@ -221,7 +213,6 @@ (this.uiDialog.next().length && this.uiDialog.appendTo('body')); this._position(this.options.position); this.uiDialog.show(this.options.show); - (this.options.autoResize && this._size()); this.moveToTop(true); // prevent tabbing out of modal dialogs @@ -315,7 +306,6 @@ (options.resizeStart && options.resizeStart.apply(self.element[0], arguments)); }, resize: function() { - (options.autoResize && self._size.apply(self)); (options.resize && options.resize.apply(self.element[0], arguments)); }, handles: resizeHandles, @@ -320,7 +310,6 @@ }, handles: resizeHandles, stop: function() { - (options.autoResize && self._size.apply(self)); (options.resizeStop && options.resizeStop.apply(self.element[0], arguments)); $.ui.dialog.overlay.resize(); } @@ -422,20 +411,7 @@ } $.widget.prototype._setData.apply(this, arguments); - }, - - _size: function() { - var container = this.uiDialogContainer, - titlebar = this.uiDialogTitlebar, - content = this.element, - tbMargin = (parseInt(content.css('margin-top'), 10) || 0) - + (parseInt(content.css('margin-bottom'), 10) || 0), - lrMargin = (parseInt(content.css('margin-left'), 10) || 0) - + (parseInt(content.css('margin-right'), 10) || 0); - content.height(container.height() - titlebar.outerHeight() - tbMargin); - content.width(container.width() - lrMargin); } - }); $.extend($.ui.dialog, { @@ -442,7 +418,6 @@ version: "@VERSION", defaults: { autoOpen: true, - autoResize: true, bgiframe: false, buttons: {}, closeOnEscape: true,