Search and Top Navigation
#11054 closed bug (fixed)
Opened February 09, 2015 06:32PM UTC
Closed February 09, 2015 06:37PM UTC
selectmenu content differs when created or refreshed when overriding _renderItem
Reported by: | gibe | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.12.0 |
Component: | ui.selectmenu | Version: | 1.11.2 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
When creating a selectmenu, the content of the button is the text of the selected option in the original menu.
When refreshing a selectememu, the content of the button is the text of the selected
<li>in the menu widget.
By default both of the same, but when overriding
_renderItemtheir content may differ.
The lines setting the text are:
- for creation (l108):
this._setText( this.buttonText, this.element.find( "option:selected" ).text() );
- for refresh (l194):
this._setText( this.buttonText, this._getSelectedItem().text() );
I guess that both values make sense. However only one should be set.
Attachments (0)
Change History (1)
Changed February 09, 2015 06:37PM UTC by comment:1
milestone: | none → 1.12.0 |
---|---|
resolution: | → fixed |
status: | new → closed |
This code no longer exists in master. See #10142.
Fixed by fb4124b7af4e87712eca9893f7aefb5fee7905de.