Skip to main content

Search and Top Navigation

#14959 closed bug (notabug)

Opened April 29, 2016 08:18AM UTC

Closed May 02, 2016 02:58PM UTC

Controlgroup: Pass direction to widget options in _initWidget()

Reported by: gabrielschulhof Owned by: gabrielschulhof
Priority: minor Milestone: none
Component: ui.controlgroup Version: git (not yet released)
Keywords: Cc:
Blocked by: Blocking:
Description

At

https://github.com/jquery/jquery-ui/blob/010f5f9d13b7d6f1c13482825547ee95d3033e40/ui/widgets/controlgroup.js#L105

the controlgroup should also pass the direction to the widget options function, because it doesn't later end up using the options for widgets in the middle, only for first and last widgets.

Attachments (0)
Change History (5)

Changed January 01, 1970 12:24AM UTC by gabrielschulhof comment:1

status: pendingnew

Changed April 29, 2016 08:42AM UTC by gabrielschulhof comment:2

OK, NM. I see that direction has been removed from the call to the widget options in master, so direction needs to be determined inside the options function if needed.

Changed May 02, 2016 01:20PM UTC by scottgonzalez comment:3

owner: → gabrielschulhof
status: newpending

Can you please explain the bug, not the requested implementation? Also, I assume that git is not the correct version and you're seeing this behavior in one of the pre-releases.

Changed May 02, 2016 02:24PM UTC by gabrielschulhof comment:4

It's not a bug. Sorry! I would've closed the ticket, but I don't have the permission to do so. Please close the ticket :)

Changed May 02, 2016 02:58PM UTC by scottgonzalez comment:5

resolution: → notabug
status: newclosed