Search and Top Navigation
#1789 closed bug (fixed)
Opened October 10, 2007 09:18AM UTC
Closed October 21, 2007 03:09AM UTC
Last modified February 26, 2009 11:12AM UTC
Impossible to initialize an empty tabset
Reported by: | klaus | Owned by: | klaus |
---|---|---|---|
Priority: | minor | Milestone: | 1.5 |
Component: | ui.core | Version: | 1.2.1 |
Keywords: | tabs | Cc: | |
Blocked by: | Blocking: |
Description
There is no possibility to initialize an empty tabset (e.g. to add all tabs dynamically.
Small fix in tabify() method (line 183) make things better:
if (this.$tabs.length && $.data(this.$tabs[o.initial], 'href')) {
Lines 362-373 of ui.tabs.js (add method):
if (url.indexOf('#') == 0) { // ajax container is created by tabify automatically var $container = $(url); // try to find an existing element before creating a new one $container = ($container.length && $container || $('<div id="' + url.replace('#', '') + '" class="' + o.containerClass + ' ' + o.hideClass + '"></div>')) [method](position > 0 ? this.$containers[position - 1] : $(this.source)); } var $foo = $('<li><a href="' + url + '"><span>' + text + '</span></a></li>'); if(position > 0) $foo[method](this.$tabs.slice(position - 1, position).parents('li:eq(0)')); else { $foo.appendTo($(this.source)); $container.removeClass('ui-tabs-hide'); }
Basically we've to check if this.$tabs array is not empty...
Attachments (0)
Change History (5)
Changed October 10, 2007 09:25AM UTC by comment:1
description: | There is no possibility to initialize an empty tabset (e.g. to add all tabs dynamically. Small fix in tabify() method (line 183) make things better: \ \ {{{ \ if (this.$tabs.length && $.data(this.$tabs[o.initial], 'href')) { \ }}} \ \ Basically we've to check if this.$tabs array is not empty... → There is no possibility to initialize an empty tabset (e.g. to add all tabs dynamically. \ \ Small fix in tabify() method (line 183) make things better: \ \ {{{ \ if (this.$tabs.length && $.data(this.$tabs[o.initial], 'href')) { \ }}} \ \ Lines 362-373 of ui.tabs.js (add method): \ \ {{{ \ if (url.indexOf('#') == 0) { // ajax container is created by tabify automatically \ var $container = $(url); \ // try to find an existing element before creating a new one \ $container = ($container.length && $container || $('<div id="' + url.replace('#', '') + '" class="' + o.containerClass + ' ' + o.hideClass + '"></div>')) \ [method](position > 0 ? this.$containers[position - 1] : $(this.source)); \ } \ var $foo = $('<li><a href="' + url + '"><span>' + text + '</span></a></li>'); \ if(position > 0) $foo[method](this.$tabs.slice(position - 1, position).parents('li:eq(0)')); \ else { \ $foo.appendTo($(this.source)); \ $container.removeClass('ui-tabs-hide'); \ } \ }}} \ \ Basically we've to check if this.$tabs array is not empty... |
---|
Changed October 20, 2007 05:49PM UTC by comment:2
status: | new → assigned |
---|
Changed October 21, 2007 03:09AM UTC by comment:3
resolution: | → fixed |
---|---|
status: | assigned → closed |
Changed May 24, 2008 03:39AM UTC by comment:4
milestone: | 1.2.2 |
---|
Milestone 1.2.2 deleted
Changed February 26, 2009 11:12AM UTC by comment:5
milestone: | → 1.5 |
---|