#1923 closed enhancement (fixed)

Opened November 14, 2007 12:35AM UTC

Closed November 14, 2007 03:45PM UTC

Last modified February 26, 2009 11:16AM UTC

shadow enhancements, optimizations and clean-ups

Reported by: brandon Owned by: paul
Priority: major Milestone: 1.5
Component: ui.core Version: 1.2.1
Keywords: Cc:
Blocked by: Blocking:
Description

I've attached a diff that includes a few optimizations, enhancements and general clean-ups of the code.

  • Saved bytes where possible
  • Renamed some variables to better match jQuery standards
  • Used jQuery.extend to map options
  • Reduced the number of calls to css
  • Removed browser detection
  • Added monitor option which defaults to false. Monitoring the element to keep the shadow in-tact is buggy and not cross browser. We shouldn't do it by default until there is better support.
  • The shadow method can be called multiple times on the same element to "rebuild" the shadow if the element has changed and is not being monitored.
  • The offset now matches the value passed in

BTW ... the test page is using and xml prologue which is throwing IE into quirks mode and is why the position _looks_ to be miscalculated. Putting the test page in standards mode resolves this issue but causes issues for the drag handles.

The monitoring in Opera does some pretty crazy stuff!

Tested using the test page in IE 6 and 7, FF 1.5 and 2, Safari 3 and Opera 9.24

Attachments (0)
Change History (5)

Changed November 14, 2007 12:36AM UTC by brandon comment:1

This should also resolve #1808

Changed November 14, 2007 03:34PM UTC by brandon comment:2

Updated patch to include a shadowDestroy method and use currentStyle in IE expressions.

Changed November 14, 2007 03:45PM UTC by brandon comment:3

description: I've attached a diff that includes a few optimizations, enhancements and general clean-ups of the code. \ \ * Saved bytes where possible \ \ * Renamed some variables to better match jQuery standards \ \ * Used jQuery.extend to map options \ \ * Reduced the number of calls to css \ \ * Removed browser detection \ \ * Added monitor option which defaults to false. Monitoring the element to keep the shadow in-tact is buggy and not cross browser. We shouldn't do it by default until there is better support. \ \ * The shadow method can be called multiple times on the same element to "rebuild" the shadow if the element has changed and is not being monitored. \ \ * The offset now matches the value passed in \ \ BTW ... the test page is using and xml prologue which is throwing IE into quirks mode and is why the position _looks_ to be miscalculated. Putting the test page in standards mode resolves this issue but causes issues for the drag handles. \ \ The monitoring in Opera does some pretty crazy stuff! \ \ Tested using the test page in IE 6 and 7, FF 1.5 and 2, Safari 3 and Opera 9.24 → I've attached a diff that includes a few optimizations, enhancements and general clean-ups of the code. \ \ * Saved bytes where possible \ \ * Renamed some variables to better match jQuery standards \ \ * Used jQuery.extend to map options \ \ * Reduced the number of calls to css \ \ * Removed browser detection \ \ * Added monitor option which defaults to false. Monitoring the element to keep the shadow in-tact is buggy and not cross browser. We shouldn't do it by default until there is better support. \ \ * The shadow method can be called multiple times on the same element to "rebuild" the shadow if the element has changed and is not being monitored. \ \ * The offset now matches the value passed in \ \ BTW ... the test page is using and xml prologue which is throwing IE into quirks mode and is why the position _looks_ to be miscalculated. Putting the test page in standards mode resolves this issue but causes issues for the drag handles. \ \ The monitoring in Opera does some pretty crazy stuff! \ \ Tested using the test page in IE 6 and 7, FF 1.5 and 2, Safari 3 and Opera 9.24 \ \
resolution: → fixed
status: new → closed

Fixed in Rev [3823]

Changed May 24, 2008 03:39AM UTC by comment:4

milestone: 1.2.2

Milestone 1.2.2 deleted

Changed February 26, 2009 11:16AM UTC by paul comment:5

milestone: → 1.5