#2122 closed bug (fixed)

Opened January 07, 2008 06:29PM UTC

Closed February 07, 2008 05:17PM UTC

Last modified February 26, 2009 11:22AM UTC

Droppable/Draggable element comparison needs to be changed on trunk.

Reported by: mnichols Owned by: paul
Priority: major Milestone: 1.5
Component: ui.core Version: 1.2.1
Keywords: droppable trunk Cc:
Blocked by: Blocking:
Description

Since the rewrite on droppable.js in the trunk, the comparisons within the droppable methods over,out, and drop need to be changed . The component now lets you drop a draggable that is the same element.

Please see attached patch.

Also note that this patch contains the fixes in #2063 where the ui object is passed to the accept function on droppable.

Attachments (0)
Change History (4)

Changed January 07, 2008 06:34PM UTC by mnichols comment:1

note that using the patch I attached here, the following is possible in the droppable's accept function:

function tryAccept(ui){

console.debug('draggable:' + ui.draggable);

console.debug('droppable:' + ui.instance);

console.debug('droppable element:' + $j(ui.instance.element).attr('id'));

console.debug('draggable element:' + $j(ui.element).attr('id'));

return true;

}

This let's the developer do runtime checks on the target droppable to see if an draggable element should be accepted or not. The current args do not allow this easily.

Changed February 07, 2008 05:17PM UTC by paul comment:2

resolution: → fixed
status: new → closed

Fixed ('this' now links to the current droppable, first argument is the draggable)

Changed May 24, 2008 03:39AM UTC by comment:3

milestone: 1.2.2

Milestone 1.2.2 deleted

Changed February 26, 2009 11:22AM UTC by paul comment:4

milestone: → 1.5