#2358 closed enhancement (fixed)

Opened February 18, 2008 07:44AM UTC

Closed October 27, 2010 07:45PM UTC

ui dialog show and hide overrides

Reported by: mnichols Owned by: scottgonzalez
Priority: major Milestone: 1.8.4
Component: ui.dialog Version: 1.5
Keywords: dialog show hide open close Cc:
Blocked by: Blocking:
Description

There is no way to control the behaviour of the show() and hide() calls on ui dialog. Therefore applying effects to the dialog is impossible, making the dialog presentation...bland.

This patch adds 'show' and 'hide' options accepting the uiDialog object to uiDialog.show() and uiDialog.hide() respectively. This lets the dev in the options do (using fx):

show: function(dialog){ $j(dialog).show('drop',{ direction: 'down',duration:1500 }); },

hide: function(dialog){ $j(dialog).hide('drop',{ direction: 'down',duration:800 }); }

Attachments (5)
Change History (17)

Changed February 19, 2008 12:32PM UTC by paul comment:1

owner: paul → rworth

Changed February 26, 2008 05:16PM UTC by rdworth comment:2

status: new → assigned

Changed May 24, 2008 03:39AM UTC by comment:3

milestone: 1.2.4

Milestone 1.2.4 deleted

Changed May 24, 2008 04:21PM UTC by paul comment:4

component: ui.core → ui.dialog
version: 1.2.3 → 1.5b4

Changed June 09, 2008 07:03PM UTC by rdworth comment:5

keywords: dialog show hide → dialog show hide open close
status: assigned → accepted

Changed June 09, 2008 07:46PM UTC by rdworth comment:6

milestone: → 1.5.1

partial fix in [255]. Still need to add support for options and/or callback handler

Changed June 09, 2008 07:51PM UTC by rdworth comment:7

version: 1.5b4 → 1.5

Changed June 26, 2008 08:17PM UTC by paul comment:8

milestone: 1.5.1 → 1.5.2

Changed June 28, 2008 11:16PM UTC by Cloudream comment:9

new patch:

if you want to use effects, set

show: {

effect:"xxx",

options:{},

speed:yyy

}

also work with original show parameters, like show:500 or show:"normal"

Changed June 29, 2008 01:57AM UTC by Cloudream comment:10

what about add a 'toggle' method to open/close dialogs?

Changed July 10, 2008 08:48PM UTC by paul comment:11

milestone: 1.5.2 → 1.6b

Changed August 16, 2008 02:34PM UTC by Cloudream comment:12

milestone: 1.6b → 1.7

Changed August 16, 2008 06:38PM UTC by Cloudream comment:13

milestone: 1.7 → 1.6

Changed October 20, 2008 06:08PM UTC by jzaefferer comment:14

milestone: 1.6 → 1.7

Deferred to 1.7, will need docs updates.

Changed June 17, 2009 01:56AM UTC by scottgonzalez comment:15

milestone: 1.next → 1.8
owner: rdworth → scott.gonzalez

Added patch to modify how show/hide/toggle works to allow specifying the effect name in the options hash. This simplifies the work needed inside individual widgets to support effects. I also created a patch that allows specifying the callback separately even when the options hash defines the effect. This makes it easy for widgets to expose options for effects while still providing the plugin's own callback. For example, dialog triggers the close callback after the hide effect completes and being able to specify the callback as the second parameter (and override any callback specified in the options hash) is much easier than having to override the callback if it exists. I think it's fine to not allow specifying a callback in the effects option because there is almost always going to be an event/callback that gets triggered by the plugin at the same time.

Changed October 27, 2010 07:45PM UTC by scottgonzalez comment:17

milestone: 1.9 → 1.8.4
resolution: → fixed
status: accepted → closed

We got this working at some point... http://jsbin.com/obuza3/edit