Ticket #2358 (closed enhancement: fixed)
ui dialog show and hide overrides
| Reported by: | mnichols | Owned by: | scott.gonzalez |
|---|---|---|---|
| Priority: | major | Milestone: | 1.8.4 |
| Component: | ui.dialog | Version: | 1.5 |
| Keywords: | dialog show hide open close | Cc: | |
| Blocking: | Blocked by: |
Description
There is no way to control the behaviour of the show() and hide() calls on ui dialog. Therefore applying effects to the dialog is impossible, making the dialog presentation...bland. This patch adds 'show' and 'hide' options accepting the uiDialog object to uiDialog.show() and uiDialog.hide() respectively. This lets the dev in the options do (using fx): show: function(dialog){ $j(dialog).show('drop',{ direction: 'down',duration:1500 }); }, hide: function(dialog){ $j(dialog).hide('drop',{ direction: 'down',duration:800 }); }
Attachments
-
uidroppable-show_and_hideoverrides.patch
(902 bytes) -
added by mnichols 5 years ago.
- show and hide ui dialog
-
dialog.patch
(1.1 KB) -
added by Cloudream 5 years ago.
-
dialog2.patch
(1.4 KB) -
added by Cloudream 5 years ago.
- support for fade effect
-
widget-effects.patch
(639 bytes) -
added by scott.gonzalez 4 years ago.
-
widget-effects-callback.patch
(638 bytes) -
added by scott.gonzalez 4 years ago.
-
dialog_r2949.patch
(1.5 KB) -
added by connorhu 4 years ago.
- updated patch for ui 1.7.2 (r2949)
Change History
Changed 5 years ago by mnichols
-
attachment
uidroppable-show_and_hideoverrides.patch
added
comment:4 Changed 5 years ago by paul
- Version changed from 1.2.3 to 1.5b4
- Component changed from ui.core to ui.dialog
comment:5 Changed 5 years ago by rdworth
- Keywords open close added
- Status changed from assigned to accepted
comment:6 Changed 5 years ago by rdworth
- Milestone set to 1.5.1
partial fix in [255]. Still need to add support for options and/or callback handler
comment:9 Changed 5 years ago by Cloudream
new patch:
if you want to use effects, set show: { effect:"xxx", options:{}, speed:yyy }
also work with original show parameters, like show:500 or show:"normal"
comment:10 Changed 5 years ago by Cloudream
what about add a 'toggle' method to open/close dialogs?
comment:14 Changed 5 years ago by joern.zaefferer
- Milestone changed from 1.6 to 1.7
Deferred to 1.7, will need docs updates.
comment:15 Changed 4 years ago by scott.gonzalez
- Owner changed from rdworth to scott.gonzalez
- Milestone changed from 1.next to 1.8
Added patch to modify how show/hide/toggle works to allow specifying the effect name in the options hash. This simplifies the work needed inside individual widgets to support effects. I also created a patch that allows specifying the callback separately even when the options hash defines the effect. This makes it easy for widgets to expose options for effects while still providing the plugin's own callback. For example, dialog triggers the close callback after the hide effect completes and being able to specify the callback as the second parameter (and override any callback specified in the options hash) is much easier than having to override the callback if it exists. I think it's fine to not allow specifying a callback in the effects option because there is almost always going to be an event/callback that gets triggered by the plugin at the same time.
Changed 4 years ago by connorhu
-
attachment
dialog_r2949.patch
added
updated patch for ui 1.7.2 (r2949)
comment:16 Changed 3 years ago by AzaToth
comment:17 Changed 3 years ago by scott.gonzalez
- Status changed from accepted to closed
- Resolution set to fixed
- Milestone changed from 1.9 to 1.8.4
We got this working at some point... http://jsbin.com/obuza3/edit
show and hide ui dialog