#2513 closed enhancement (fixed)

Opened March 14, 2008 03:23PM UTC

Closed December 22, 2008 03:11PM UTC

Last modified October 11, 2012 09:15PM UTC

Accordion: classNames should be default

Reported by: neojp Owned by: joern
Priority: trivial Milestone:
Component: ui.accordion Version: 1.5
Keywords: Cc:
Blocked by: Blocking:
Description

Theme related classNames should be added to the accordions by default.

$(container).addClass("ui-accordion-container ui-accordion");

// add classNames and spans to header
options.headers.addClass('ui-accordion-link').prepend('<span class="ui-accordion-left"></span>').append('<span class="ui-accordion-right"></span>');
Attachments (0)
Change History (9)

Changed March 14, 2008 03:28PM UTC by neojp comment:1

Talking about a theming issue, headers should be relative positioned.

ul.ui-accordion-container li a.ui-accordion-link { position: relative }

Changed March 14, 2008 04:35PM UTC by paul comment:2

owner: paul → joern

Changed March 16, 2008 04:06AM UTC by scottgonzalez comment:3

Why are both .ui-accordion and .ui-accordion-container needed if they're applied to the same element?

Also, why is relative positioning required? I'm asking because this was actually removed in [4420] to fix #2127.

Changed March 23, 2008 06:36PM UTC by neojp comment:4

postion:relative; is not that necessary if you don't append the header spans. If they are not positioned inside a reltive they will appear on the top right corner of the document.

Regarding this,

$(container).addClass("ui-accordion-container ui-accordion");

I'm not sure why the accordion plugin uses 2 different classNames for the same element, since it never uses one. I think we could get rid of one and change the css styles to match the className choosen.

Changed May 24, 2008 07:35PM UTC by paul comment:5

component: ui.core → ui.accordion
version: → 1.5b4

Changed June 25, 2008 12:00AM UTC by paul comment:6

version: 1.5b4 → 1.5

Changed August 16, 2008 06:29PM UTC by Cloudream comment:7

milestone: → TDB

Changed December 22, 2008 03:11PM UTC by jzaefferer comment:8

resolution: → fixed
status: new → closed

Fixed as part of #3646

Changed October 11, 2012 09:15PM UTC by scottgonzalez comment:9

milestone: TBD

Milestone TBD deleted