Ticket #2513 (closed enhancement: fixed)

Opened 6 years ago

Last modified 22 months ago

Accordion: classNames should be default

Reported by: neojp Owned by: joern
Priority: trivial Milestone:
Component: ui.accordion Version: 1.5
Keywords: Cc:
Blocking: Blocked by:

Description

Theme related classNames should be added to the accordions by default.

$(container).addClass("ui-accordion-container ui-accordion");
// add classNames and spans to header
options.headers.addClass('ui-accordion-link').prepend('<span class="ui-accordion-left"></span>').append('<span class="ui-accordion-right"></span>');

Attachments

ui.accordion_theme.diff Download (996 bytes) - added by neojp 6 years ago.
UI Accordion: add classnames, and spans for themes
flora.accordion.diff Download (1.1 KB) - added by neojp 6 years ago.
accordion flora theme, position relative added to headers

Change History

Changed 6 years ago by neojp

UI Accordion: add classnames, and spans for themes

comment:1 Changed 6 years ago by neojp

Talking about a theming issue, headers should be relative positioned.

ul.ui-accordion-container li a.ui-accordion-link { position: relative }

Changed 6 years ago by neojp

accordion flora theme, position relative added to headers

comment:2 Changed 6 years ago by paul

  • Owner changed from paul to joern

comment:3 Changed 6 years ago by scott.gonzalez

Why are both .ui-accordion and .ui-accordion-container needed if they're applied to the same element?

Also, why is relative positioning required? I'm asking because this was actually removed in [4420] to fix #2127.

comment:4 Changed 6 years ago by neojp

postion:relative; is not that necessary if you don't append the header spans. If they are not positioned inside a reltive they will appear on the top right corner of the document.

Regarding this,

$(container).addClass("ui-accordion-container ui-accordion");

I'm not sure why the accordion plugin uses 2 different classNames for the same element, since it never uses one. I think we could get rid of one and change the css styles to match the className choosen.

comment:5 Changed 6 years ago by paul

  • Version set to 1.5b4
  • Component changed from ui.core to ui.accordion

comment:6 Changed 6 years ago by paul

  • Version changed from 1.5b4 to 1.5

comment:7 Changed 6 years ago by Cloudream

  • Milestone set to TDB

comment:8 Changed 6 years ago by joern.zaefferer

  • Status changed from new to closed
  • Resolution set to fixed

Fixed as part of #3646

comment:9 Changed 22 months ago by scott.gonzalez

  • Milestone TBD deleted

Milestone TBD deleted

Note: See TracTickets for help on using tickets.