#2591 closed bug (fixed)

Opened March 26, 2008 11:29PM UTC

Closed April 13, 2008 05:41PM UTC

Last modified February 26, 2009 12:02PM UTC

Slider size method only returns the width of the slider

Reported by: natecavanaugh Owned by: joern
Priority: major Milestone: 1.5
Component: ui.core Version: 1.2.3
Keywords: Cc:
Blocked by: Blocking:
Description

When checking for a sliders size, the size method only returns it's outerWidth, however, when using a vertical slider, you need the height of the slider, not its width.

The fix is to change this on line 192 in ui.slider.js:

return this.actualSize || (this.actualSize = this.element.outerWidth());

to this:

return this.actualSize || (this.actualSize = (this.options.axis == 'horizontal') ? this.element.outerWidth() : this.element.outerHeight());

Attachments (0)
Change History (5)

Changed March 26, 2008 11:35PM UTC by natecavanaugh comment:1

Somehow the pipes are missing:

return this.actualSize | | (this.actualSize = (this.options.axis == 'horizontal') ? this.element.outerWidth() : this.element.outerHeight());

Changed March 27, 2008 02:32PM UTC by paul comment:2

owner: paul → joern

Changed April 13, 2008 05:41PM UTC by joern comment:3

resolution: → fixed
status: new → closed

That got fixed some time ago, see latest revision.

Changed May 24, 2008 03:39AM UTC by comment:4

milestone: 1.2.4

Milestone 1.2.4 deleted

Changed February 26, 2009 12:02PM UTC by paul comment:5

milestone: → 1.5