Search and Top Navigation
#2867 closed bug (fixed)
Opened May 14, 2008 04:17PM UTC
Closed May 30, 2008 07:40AM UTC
Last modified February 26, 2009 12:11PM UTC
tabTemplate global replace
| Reported by: | mdalessio | Owned by: | klaus.hartl |
|---|---|---|---|
| Priority: | major | Milestone: | 1.5 |
| Component: | ui.tabs | Version: | 1.5b4 |
| Keywords: | tabs | Cc: | |
| Blocked by: | Blocking: |
Description
When replacing #{href} and #{label} in the ui.tabs tabTemplate, the replace is not global.
It probably should be. Patch attached.
<offtopic>
This problem was uncovered while trying to get a fixed id for my dynamic tab. The proper way to get a fixed id is to use the "title=" attribute in my anchor tag, but for dynamically-added tabs, this is done in the tabTemplate.
Probably, "title" should be able to be passed to tabs('add',...). Maybe a config object would be good here?
</offtopic>
Attachments (0)
Change History (5)
Changed May 24, 2008 03:39AM UTC by comment:1
| milestone: | 1.2.4 |
|---|
Changed May 24, 2008 04:06AM UTC by comment:2
| component: | ui.core → ui.tabs |
|---|---|
| version: | 1.2.3 → 1.5b4 |
Changed May 24, 2008 09:58PM UTC by comment:3
| owner: | paul → klaus.hartl |
|---|---|
| status: | new → assigned |
Changed May 30, 2008 07:40AM UTC by comment:4
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Fixed in [77]. Thanks.
Changed February 26, 2009 12:11PM UTC by comment:5
| milestone: | → 1.5 |
|---|
Milestone 1.2.4 deleted