Ticket #3081 (closed bug: fixed)
Slider keyboard interaction should match DHTML styleguide
| Reported by: | davidb | Owned by: | davidb |
|---|---|---|---|
| Priority: | major | Milestone: | 1.5 |
| Component: | ui.core | Version: | 1.5.1 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
See http://dev.aol.com/dhtml_style_guide#slider for appropriate keyboard interaction.
Attachments
-
slider.diff
(614 bytes) -
added by davidb 5 years ago.
- A minimal patch that fixes arrow interaction.
-
slider.2.diff
(1.1 KB) -
added by davidb 5 years ago.
- completes keyboard implementation (not tested on all browsers)
Change History
Changed 5 years ago by davidb
-
attachment
slider.diff
added
Changed 5 years ago by davidb
-
attachment
slider.2.diff
added
completes keyboard implementation (not tested on all browsers)
comment:1 Changed 5 years ago by davidb
With these patches I'm really just guessing as to the desired style, and am basing my guessing on the previously existing implementation. This implementation might be a little hard to comprehend? It might err on the side of tightness over clarity.
Shall we create a keycode map so that we don't hard code the keys? Also, I notice a switch expression is used in the date picker... we will probably want to be consistent across plugins.
comment:2 Changed 5 years ago by davidb
Also note I think we may want a 'paging' option similar to stepping, that describes the amount to 'page' the slider thumb when the user presses pageup/dwn. I've captured this desire in a partially implemented 'pageStep' function in patch2.
comment:3 Changed 5 years ago by davidb
Note I committed the first patch, but feel I should wait for feedback on the second.
comment:4 Changed 5 years ago by davidb
- Owner changed from paul to davidb
- Status changed from new to assigned
comment:5 Changed 5 years ago by davidb
- Status changed from assigned to closed
- Resolution set to fixed
Created ticket:3096 for paging (page/up/down option).
A minimal patch that fixes arrow interaction.