Search and Top Navigation
#3117 closed bug (fixed)
Opened July 19, 2008 11:13AM UTC
Closed December 19, 2008 06:11PM UTC
fix for autoResize in dialog with button pane
Reported by: | mgl | Owned by: | rdworth |
---|---|---|---|
Priority: | major | Milestone: | 1.7 |
Component: | ui.dialog | Version: | 1.5.2 |
Keywords: | dialog buttonpane resize autoresize | Cc: | |
Blocked by: | Blocking: |
Description
I already posted this in the jQuery UI google group, but I figured it might be better to create a proper ticket. Here's what I posted on google groups:
I've got a dialog working, and I notice now that autoResize seems to
be working to make the div that is contained by my dialog fit to the
inside of the dialog properly...very nice. However, the problem I've
got now is that it doesn't account for the height of the button pane
if it is visible, so if I'm using the button pane, I have to disable
autoResize, and implement the same workaround I've been using with the
resize event...
So...here's my fix for the size method, which includes the button pane
in the height calculation (starting at line 240):
size: function() {
var container = this.uiDialogContainer,
titlebar = this.uiDialogTitlebar,
content = this.element,
buttonpane = this.uiDialogButtonPane;
tbMargin = parseInt(content.css('margin-top'),10) + parseInt(content.css('margin-bottom'),10),
lrMargin = parseInt(content.css('margin-left'),10) + parseInt(content.css('margin-right'),10);
content.height(container.height() - titlebar.outerHeight() - buttonpane.outerHeight() - tbMargin);
content.width(container.width() - lrMargin);
},
Attachments (0)
Change History (4)
Changed July 19, 2008 11:14AM UTC by comment:1
Changed July 24, 2008 10:25AM UTC by comment:2
owner: | scott.gonzalez → rdworth |
---|---|
status: | new → assigned |
version: | 1.5.1 → 1.5.2 |
Changed August 17, 2008 10:04AM UTC by comment:3
milestone: | → TDB |
---|
Changed December 19, 2008 06:11PM UTC by comment:4
milestone: | TBD → 1.6 |
---|---|
resolution: | → fixed |
status: | assigned → closed |
The autoResize option was removed in r1177. Dialogs now always auto-resize.
P.S.: This is with version 1.5.2, but that wasn't an option in this Trac.