Search and Top Navigation
#3174 closed enhancement (fixed)
Opened August 11, 2008 11:19PM UTC
Closed September 18, 2008 09:54AM UTC
Last modified August 28, 2009 08:10AM UTC
Return on enableSelection and disableSelection
Reported by: | jneal@liferay.com | Owned by: | paul |
---|---|---|---|
Priority: | minor | Milestone: | 1.6rc2 |
Component: | ui.core | Version: | 1.5.2 |
Keywords: | enableSelection, disableSelection | Cc: | jneal@liferay.com |
Blocked by: | Blocking: |
Description
The enableSelection and disableSelection functions return nothing, and it would be nice if they returned the jQuery selector so that they can support further function chaining. Adding the return would be as simple as...
disableSelection: function(el) {
return $(el).attr('unselectable', 'on').css('MozUserSelect', 'none');
},
enableSelection: function(el) {
return $(el).attr('unselectable', 'off').css('MozUserSelect', '');
},
Oh, wouldn't it be nice?
Jonathan
Attachments (0)
Change History (5)
Changed August 17, 2008 10:18AM UTC by comment:1
milestone: | → TDB |
---|---|
priority: | major → minor |
Changed September 18, 2008 09:54AM UTC by comment:2
Good idea, thanks! Implemented in r690.
Changed September 18, 2008 09:54AM UTC by comment:3
resolution: | → fixed |
---|---|
status: | new → closed |
Changed November 19, 2008 04:37AM UTC by comment:4
milestone: | TBD → 1.6rc2 |
---|
Changed August 28, 2009 08:10AM UTC by comment:5
could you please add suport for Opera browsers?