#3188 closed bug (fixed)

Opened August 15, 2008 07:48AM UTC

Closed August 18, 2008 07:00AM UTC

Last modified November 19, 2008 04:28AM UTC

prevent exposure of internal methods

Reported by: scottgonzalez Owned by: scottgonzalez
Priority: blocker Milestone: 1.6rc1
Component: ui.core Version: 1.5.2
Keywords: Cc:
Blocked by: Blocking:
Description

Internal plugin methods should not be callable using the plugin API.

Example:

$(el).plugin('internalMethod');
Attachments (0)
Change History (10)

Changed August 16, 2008 07:13AM UTC by scottgonzalez comment:1

status: new → accepted

This will be handled by the widget factory. Precede internal method names with an underscore to prevent exposure through the API.

Changed August 16, 2008 07:18AM UTC by scottgonzalez comment:2

The widget factory was modified to support this in r547.

Changed August 16, 2008 07:28AM UTC by scottgonzalez comment:3

resolution: → fixed
status: accepted → closed

There is a separate ticket for each plugin:

#3194 ui.accordion

#3195 ui.autocomplete

#3196 ui.colorpicker

#3197 ui.datepicker

#3198 ui.dialog

#3200 ui.draggable

#3201 ui.droppable

#3202 ui.magnifier

#3203 ui.progressbar

#3204 ui.resizable

#3205 ui.selectable

#3206 ui.slider

#3209 ui.sortable

#3207 ui.spinner

#3208 ui.tabs

Changed August 16, 2008 01:11PM UTC by Cloudream comment:4

resolution: fixed
status: closed → reopened

After individual plugins fixed, we should fix init/plugins to _init/_plugins

Changed August 16, 2008 08:53PM UTC by scottgonzalez comment:5

Widget factory methods updated in r552.

Changed August 17, 2008 09:17AM UTC by Cloudream comment:6

only mouse* in drag/drop/sort/select left.

Changed August 17, 2008 09:03PM UTC by Cloudream comment:7

resolution: → fixed
status: reopened → closed

[563]

Changed August 17, 2008 11:50PM UTC by scottgonzalez comment:8

resolution: fixed
status: closed → reopened

mouse* in slider still needs to be updated.

Changed August 18, 2008 07:00AM UTC by Cloudream comment:9

resolution: → fixed
status: reopened → closed

done and pass the test case.

Changed November 19, 2008 04:28AM UTC by rdworth comment:10

milestone: 1.6 → 1.6rc1