dialog does not take padding into account when positioning the window

[wichert]

The problem is that position() uses the inner sizes, while it should be using the outer size. This is a patch:

Index: ui.dialog.js
===================================================================
--- ui.dialog.js        (revision 2931)
+++ ui.dialog.js        (working copy)
@@ -203,11 +203,11 @@
                                        pLeft += 0;
                                        break;
                                case 'right':
-                                       pLeft += wnd.width() - this.uiDialog.width();
+                                       pLeft += wnd.width() - this.uiDialog.outerWidth();
                                        break;
                                default:
                                case 'center':
-                                       pLeft += (wnd.width() - this.uiDialog.width()) / 2;
+                                       pLeft += (wnd.width() - this.uiDialog.outerWidth()) / 2;
                        }
                }
                if (pos[1].constructor == Number) {
@@ -218,11 +218,11 @@
                                        pTop += 0;
                                        break;
                                case 'bottom':
-                                       pTop += wnd.height() - this.uiDialog.height();
+                                       pTop += wnd.height() - this.uiDialog.outerHeight();
                                        break;
                                default:
                                case 'middle':
-                                       pTop += (wnd.height() - this.uiDialog.height()) / 2;
+                                       pTop += (wnd.height() - this.uiDialog.outerHeight()) / 2;
                        }
                }
 

[scott.gonzalez]

This doesn't seem to be a problem anymore. If you continue to have problems after 1.6rc3, feel free to re-open this ticket.

[scott.gonzalez]

Ugh, accidentally tested on the server while makes changes locally. This bug does still exist.

[scott.gonzalez]

Fixed in r1184. Thanks for the patch.