#3221 closed bug (fixed)

Opened August 18, 2008 03:21AM UTC

Closed December 19, 2008 08:35PM UTC

dialog does not take padding into account when positioning the window

Reported by: wichert Owned by: rdworth
Priority: minor Milestone: 1.7
Component: ui.dialog Version: 1.5.2
Keywords: Cc:
Blocked by: Blocking:
Description

The problem is that position() uses the inner sizes, while it should be using the outer size. This is a patch:

Index: ui.dialog.js
===================================================================
--- ui.dialog.js        (revision 2931)
+++ ui.dialog.js        (working copy)
@@ -203,11 +203,11 @@
                                        pLeft += 0;
                                        break;
                                case 'right':
-                                       pLeft += wnd.width() - this.uiDialog.width();
+                                       pLeft += wnd.width() - this.uiDialog.outerWidth();
                                        break;
                                default:
                                case 'center':
-                                       pLeft += (wnd.width() - this.uiDialog.width()) / 2;
+                                       pLeft += (wnd.width() - this.uiDialog.outerWidth()) / 2;
                        }
                }
                if (pos[1].constructor == Number) {
@@ -218,11 +218,11 @@
                                        pTop += 0;
                                        break;
                                case 'bottom':
-                                       pTop += wnd.height() - this.uiDialog.height();
+                                       pTop += wnd.height() - this.uiDialog.outerHeight();
                                        break;
                                default:
                                case 'middle':
-                                       pTop += (wnd.height() - this.uiDialog.height()) / 2;
+                                       pTop += (wnd.height() - this.uiDialog.outerHeight()) / 2;
                        }
                }
Attachments (0)
Change History (4)

Changed August 18, 2008 11:56PM UTC by scottgonzalez comment:1

owner: scott.gonzalez → rdworth
status: new → assigned

Changed December 19, 2008 08:28PM UTC by scottgonzalez comment:2

milestone: TBD → 1.6
resolution: → fixed
status: assigned → closed

This doesn't seem to be a problem anymore. If you continue to have problems after 1.6rc3, feel free to re-open this ticket.

Changed December 19, 2008 08:33PM UTC by scottgonzalez comment:3

resolution: fixed
status: closed → reopened

Ugh, accidentally tested on the server while makes changes locally. This bug does still exist.

Changed December 19, 2008 08:35PM UTC by scottgonzalez comment:4

resolution: → fixed
status: reopened → closed

Fixed in r1184. Thanks for the patch.