Ticket #3451 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

ARIA work requires unique id for dialog title node.

Reported by: davidb Owned by: scott.gonzalez
Priority: major Milestone: 1.7
Component: ui.dialog Version: 1.6rc1
Keywords: Cc: michelled
Blocking: Blocked by:

Description

We need to put an ARIA relation on the uiDialog node. This ARIA relation, aria-labelledby requires a value of 1 or more node ids. This allows the browser to build an accessible name for uiDialog from the nodes referred to by aria-labelledby. e.g. <div class="ui-dialog" role="dialog" labelledby="ui-dialog-title-unique-id"...

In discussing this with Scott we decided that a unique id needs to be generated for the title element of a jquery dialog.

Attachments

labelledby.patch Download (1.5 KB) - added by scott.gonzalez 5 years ago.

Change History

Changed 5 years ago by scott.gonzalez

comment:1 Changed 5 years ago by davidb

Scott, the patch looks great.

comment:2 Changed 5 years ago by davidb

...except, you don't need to add the ARIA yet. We're normalizing some util for ARIA in core. We're mostly there and will update you on the work. Dialog is out already first consumer of this API in our sandbox.

comment:3 Changed 5 years ago by scott.gonzalez

  • Status changed from new to closed
  • Type changed from bug to enhancement
  • Resolution set to fixed
  • Milestone changed from TBD to 1.6

Fixed in r702.

Note: See TracTickets for help on using tickets.