improvement for _trigger-Method and more consistency in slider events

Hi,

this is related to ui.core and ui.slider.

I realy like the way ui is triggering events, but i think they could provide more information and consistency in some cases.

I added a diff for both, but will explain the changes here:

1. The instance-property

In ui 1.5 the all events passed the a reference to the actual ui-instance. I saw that this was changed. But this was a very nice and simple way to get the reference (I know, that i can get the reference in another way). The other problem with changing this, is, that this change could break a lot of existing code. It would be great, if all events would have a subset of same properties (i.e. instance, options). So I changed the line in the _trigger-Method to this:

return this.element.triggerHandler(eventName, [e, $.extend({instance: this, options: this.options}, data)], this.options[type]); (I added something similiar to the propagate-Method).

2. The slide-Event is not consistent (Bug?)

Sometimes the slide-Event is passing two arguments and sometimes it call the event handler with 3 events. This was fixed in the _trigger-Method, but not in the propagate-Method of ui.slider. So i added the following line:

e = e || $.event.fix({ type: n, target: this.element[0] });

3. noPropagation-parameter in the moveTo-method of ui.slider

I think you have added this feature to break possible circular calling "widgets" (i hope it is clear what i mean.).

I think there is another way to do this. This parameter makes the hole event of the slider-widget unreliable. For example someone makes an extension to the slider an adds his eventlistener. The author of a page needs this extension, but also needs to break this circular calling. But this would break also the extension.

I think it would be much better, if you would pass the parameter to the eventhandler and the eventhandler could then decide what to do. To achieve this, i changed the name of the noPropagation-parameter to callerInfo and this parameter will be passed to the propagate-method:

this._propagate('start', null, {callerInfo: callerInfo});

I know my english is sometimes realy bad. I hope you understand, what i think.