Ticket #3553 (closed bug: fixed)

Opened 5 years ago

Last modified 19 months ago

Accordion needs keyboard and ARIA support

Reported by: davidb Owned by: davidb
Priority: major Milestone: 1.6
Component: [meta] ui.a11y Version: 1.6rc2
Keywords: Cc: michelled
Blocking: Blocked by:

Description

Currently accordion does not support a keyboard or screen reader interaction. We should fix this here so that jQuery users can benefit. This should probably be high priority given that it is locking out some features of the Mozilla addons website.

Blocks:  mozilla bug 462411

Attachments

taborder-based.diff Download (3.0 KB) - added by davidb 5 years ago.
the taborder based fix (removed unecessary aria-hidden)
3553.diff Download (3.7 KB) - added by davidb 5 years ago.
uses arrows. one header in tab order. removes header links from tab order needs review
3553.2.diff Download (3.8 KB) - added by davidb 5 years ago.
this one doesn't auto-expand when arrowing.
3553.3.diff Download (4.1 KB) - added by davidb 5 years ago.
makes sure at least one header in tab order, improved tabindex modification
3553toCommit.diff Download (4.1 KB) - added by davidb 5 years ago.
patch just committed to trunk. tested in FF2/3, Safari, IE8

Change History

comment:1 Changed 5 years ago by davidb

  • Keywords michelled added

When I get a chance, I'll post a patch that follows the  http://dev.aol.com/dhtml_style_guide; unless we want to keep the 'every header is in the tab order' keyboard interaction. It will be a bit more work to follow the styleguide, and currently there is an agenda item to review an accordion proposal from James Craig, which I believe is more akin to the current patch.

Changed 5 years ago by davidb

the taborder based fix (removed unecessary aria-hidden)

Changed 5 years ago by davidb

uses arrows. one header in tab order. removes header links from tab order needs review

Changed 5 years ago by davidb

this one doesn't auto-expand when arrowing.

Changed 5 years ago by davidb

makes sure at least one header in tab order, improved tabindex modification

comment:2 Changed 5 years ago by davidb

  • Cc michelled added
  • Keywords michelled removed

Changed 5 years ago by davidb

patch just committed to trunk. tested in FF2/3, Safari, IE8

comment:3 Changed 4 years ago by scott.gonzalez

  • Milestone changed from TBD to 1.next

comment:4 Changed 19 months ago by scott.gonzalez

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from 1.next to 1.6
Note: See TracTickets for help on using tickets.