Ticket #3556 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

Draggable connectToSortable revert bug

Reported by: Flat Stanley Owned by: paul
Priority: minor Milestone: 1.7
Component: ui.draggable Version: 1.5.2
Keywords: connectToSortable revert Cc:
Blocking: Blocked by:

Description

When we set a revert: "invalid" to a draggable connected to a sortable, we would expect that dropping the draggable onto the sortable would be considered a "valid" drop. However, I find that the item reverts to its original position and then adds itself to the sortable list. So, it seems to be considered an "invalid" drop.

Attachments

sortable-3556.patch Download (1012 bytes) - added by alan.castro 6 years ago.
patch that fixes revert problem with draggable that has connectToSortable option.

Change History

comment:1 in reply to: ↑ description Changed 6 years ago by Marc Diethelm

I found this to be fixed in trunk. Should be released in 1.6rc3. (I'm not on the team.)

comment:2 Changed 6 years ago by scott.gonzalez

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from TBD to 1.6

Closing as fixed based on Marc's comment. Feel free to re-open this ticket if you continue to have problems with 1.6rc3+.

comment:3 Changed 6 years ago by Marc Diethelm

tested with 1.6rc4

The bug is still valid unfortunately. Maybe I can make a testcase tomorrow.

  • Trac tells me I don't have permission to reopen. *sigh*

comment:4 Changed 6 years ago by rdworth

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:5 Changed 6 years ago by alan.castro

I'm attaching a patch that fixes this problem. I used the trunk version.

Changed 6 years ago by alan.castro

patch that fixes revert problem with draggable that has connectToSortable option.

comment:6 Changed 6 years ago by paul

  • Status changed from reopened to closed
  • Resolution set to fixed

Was a bit more difficult to fix than the provided patch (the provided patch simply kills revert if connectToSortable is used). Fixed in r1557.

Note: See TracTickets for help on using tickets.