Ticket #3596 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Replace global jQuery with dollar sign

Reported by: vmx Owned by: scott.gonzalez
Priority: blocker Milestone: 1.7
Component: ui.core Version: 1.6rc2
Keywords: Cc:
Blocking: Blocked by:

Description

Some files use "jQuery" instead of the dollar sign. This is a bad idea, as you loose the possibility to pass a custom jQuery object into the closures that surround the plugins.

It passes the test suite.

Attachments

global-jquery-to-dollar-sign.patch Download (4.7 KB) - added by vmx 5 years ago.
Change "jQuery" to $

Change History

Changed 5 years ago by vmx

Change "jQuery" to $

comment:1 Changed 5 years ago by vmx

I forgot to mention that I haven't fixed the datepicker as it contains so many references to "jQuery" in onclick attributes. Fixing that would need a major refactoring.

comment:2 Changed 5 years ago by scott.gonzalez

  • Owner changed from paul to scott.gonzalez
  • Priority changed from major to blocker
  • Status changed from new to assigned

Already fixed in progressbar.

comment:3 Changed 5 years ago by scott.gonzalez

  • Status changed from assigned to closed
  • Type changed from enhancement to bug
  • Resolution set to fixed

Fixed in r951.

Note: See TracTickets for help on using tickets.