Ticket #3648 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

Dialog: Update markup to new UI CSS Framework specs

Reported by: joern.zaefferer Owned by: scott.gonzalez
Priority: blocker Milestone: 1.7
Component: ui.dialog Version: 1.6rc2
Keywords: Cc:
Blocking: Blocked by:

Description

The new jQuery UI CSS Framework was finalized and will be in 1.6rc3. The appropriate changes need to made to the plugin. For markup reference, see

 http://jquery-ui.googlecode.com/svn/trunk/tests/static/dialog.html

Attachments

dialog-container-r1174.patch Download (4.9 KB) - added by scott.gonzalez 4 years ago.
Removal of container div and autoResize option
dialog-container-r1175.patch Download (5.9 KB) - added by scott.gonzalez 4 years ago.

Change History

comment:1 Changed 4 years ago by scott.gonzalez

  • Owner set to scott.gonzalez
  • Status changed from new to accepted

Mostly fixed in r1091. The .ui-dialog-container still needs to be removed to match the static markup. I didn't remove this yet because I'm not sure what the implications are.

comment:2 Changed 4 years ago by joern.zaefferer

The 1.6 release will break compability, so you should just remove that class to get things cleaned up.

Changed 4 years ago by scott.gonzalez

Removal of container div and autoResize option

comment:3 Changed 4 years ago by scott.gonzalez

Also currently missing the se resizable icon.

comment:4 Changed 4 years ago by scott.gonzalez

The current patch for removing the container div doesn't handle buttons properly.

comment:5 Changed 4 years ago by scott.gonzalez

The new patch fixes the problem with the buttonpnae positioning.

Changed 4 years ago by scott.gonzalez

comment:6 Changed 4 years ago by scott.gonzalez

  • Status changed from accepted to closed
  • Resolution set to fixed

Fixed in r1177.

Note: See TracTickets for help on using tickets.