#3938 closed bug (fixed)

Opened January 25, 2009 03:35PM UTC

Closed November 06, 2009 02:47AM UTC

Last modified November 16, 2009 02:59AM UTC

Add borderColor-step-method

Reported by: trixta Owned by:
Priority: major Milestone: 1.8
Component: ui.effects.core Version: 1.6rc5
Keywords: Cc:
Blocked by: Blocking:
Description

If you are using the animateClass-method IE tries to use the shorthand property 'borderColor', instead of borderBottomColor, borderTopColor etc..

To get this work, i added the following lines to the effects.core:

var colorPropterties = ['backgroundColor', 'borderBottomColor', 'borderLeftColor', ...];

if (!$.browser.msie) {

colorPropterties.push('borderColor');

}

create color-step functions:

$.each(colorPropterties, ...

modified version of effects.core (bugfixes, enhancements and new features): http:www.protofunc.com/scripts/jquery/classanimation/

Attachments (2)
  • borderColorFix.patch (1.4 KB) - added by bman654 September 09, 2009 12:38AM UTC.

    This patch resolves the problem

  • test.html (0.7 KB) - added by bman654 September 09, 2009 12:37AM UTC.

    Shows the problem.

Change History (5)

Changed January 26, 2009 04:40PM UTC by paul comment:1

milestone: TBD → 1.next
priority: minor → major

Changed February 16, 2009 10:33PM UTC by trixta comment:2

I think, I was wrong on this.

The borderColor-Property should be filtered out by the animateClass-Method, instead. If a borderColor (for example: borderLeftColor) changes animateclass trys to animate both bordercolor + borderLeftColor.

Changed September 05, 2009 08:32PM UTC by bman654 comment:3

Please do not just filter away "borderColor" - I encountered this exact bug yesterday. If you are concerned about possibly animating both borderColor and borderLeftColor, then occurrences of borderColor should be replaced with borderLeftColor, borderTopColor, borderBottomColor, borderRightColor and only those that are already in the property list should thrown away.

Changed November 06, 2009 02:47AM UTC by scottgonzalez comment:4

milestone: 1.next → 1.8
resolution: → fixed
status: new → closed

Fixed in r3411 by adding borderColor to the list of supported properties. I can't see any negative side effects to this, other than an extremely minor performance hit.

Changed November 16, 2009 02:59AM UTC by scottgonzalez comment:5

Decided to go with trixta's suggestion and filter out borderColor. Whenever borderColor needs to be animated it always shows up as the individual properties. I'm now filtering all shorthand styles.