Ticket #3968 (closed bug: fixed)

Opened 4 years ago

Last modified 2 years ago

effects explode: explodes from the right instead of from the center

Reported by: rdworth Owned by: gnarf
Priority: major Milestone: 1.9.0
Component: ui.effects.* (individual effect) Version: 1.6rc5
Keywords: Cc:
Blocking: Blocked by:

Description

The explode effect when viewed in Safari is centered at the right middle instead of the center middle. See

 http://jquery-ui.googlecode.com/svn/tags/1.6rc5/demos/effects_showhide/explode.html

Change History

comment:1 Changed 4 years ago by scott.gonzalez

This is caused by a bug in Safari where the computed value for marginRight is actually all of the remaining space between the right edge of the element and the right edge of the parent element. This can be fixed by calling .outerWidth() without passing in true, but then the effect won't work on elements that have a margin.

comment:2 Changed 4 years ago by scott.gonzalez

  • Summary changed from effects explode: explodes from the right instead of from the center to effects explode: [webkit bug] explodes from the right instead of from the center

comment:3 Changed 4 years ago by scott.gonzalez

Using absolute positioning prevents this problem.

comment:4 Changed 4 years ago by scott.gonzalez

  • Milestone changed from 1.6 to 1.next

Fixed demo in r1954. Bumping to 1.next.

comment:5 Changed 3 years ago by scott.gonzalez

  • Priority changed from critical to major

comment:6 Changed 2 years ago by gnarf

I'm beginning to think after some digging that the explode effect actually wants .outerWidth() not .outerWidth(true) a few other mathematical improvements led me here:  http://jsfiddle.net/gnarf/QJ9Y9/

comment:7 Changed 2 years ago by scott.gonzalez

That looks much better.

comment:8 Changed 2 years ago by gnarf

  • Owner set to gnarf
  • Status changed from new to assigned
  • Milestone changed from 1.next to 1.9

comment:9 Changed 2 years ago by gnarf

  • Summary changed from effects explode: [webkit bug] explodes from the right instead of from the center to effects explode: explodes from the right instead of from the center

comment:11 Changed 2 years ago by scott.gonzalez

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed in 39dcad6e498a4c7b1507f188ea7733ff5ac1eb26.

Note: See TracTickets for help on using tickets.