#4012 closed bug (fixed)

Opened January 30, 2009 07:33PM UTC

Closed February 12, 2009 11:57AM UTC

Minify js error

Reported by: mharpste Owned by:
Priority: blocker Milestone: 1.7
Component: [meta] ui.downloadbuilder Version: 1.5.3
Keywords: minify Cc:
Blocked by: Blocking:
Description

Hi,

I downloaded the ui core and interactions js file and am currently getting a javascript error on the minified version of the js file (The uncompressed version doesn't throw an error).

The error shows up in FF2 and FF3 at least. I'll try and attach the two version of the files that were generated for me. I downloaded them about an hour ago (1:30pm EST Friday January 30th 2009)

Attachments (2)
Change History (4)

Changed January 31, 2009 02:57AM UTC by rdworth comment:1

component: ui.core → [meta] ui.downloadbuilder
milestone: TBD → 1.6
priority: minor → blocker

Changed February 10, 2009 01:41PM UTC by initjh comment:2

I can confirm this issue is still present.

The problem is that semi-colons need to be inserted between the functions as you get minified code like this:

})(jQuery)(function(C) {

and

})(jQuery)(function(A) {

which should be

})(jQuery);(function(A) {

Changed February 10, 2009 02:58PM UTC by initjh comment:3

;(function($))(jQuery);

A fix would be to go into each plug-in and add a semi-colon in front of every enclosure, such as in effects.bounce.

Or (and as a fallback) you can hack the build script to check for and add ; before minifying it.

Something like $code_to_minify = preg_replace("/(?<!;)\\(function\\(\\$/",";(function(\\$", $code_to_minify);

Changed February 12, 2009 11:57AM UTC by rdworth comment:4

resolution: → fixed
status: new → closed

Thanks initjh. Fixed.