#4126 closed bug (fixed)

Opened February 11, 2009 05:31PM UTC

Closed February 13, 2009 03:09AM UTC

focus on dialog open should be constrained to the contents of the dialog

Reported by:	jonspalmer	Owned by:	scottgonzalez
Priority:	critical	Milestone:	1.7
Component:	ui.dialog	Version:	1.6rc6
Keywords:		Cc:
Blocked by:		Blocking:

Description

The open function of dialog attempts to find the first tabbable element and give it the focus via:

this.uiDialog.find(':tabbable:first').focus();

however if the dialog has a close icon then it will be first tabbable element and it receives the focus. Instead the find should be done on

this.element

not

thus.uiDialog

so that the focus is applied to the contents and not the header.

might be some overlap with #3768

Attachments (0)

Change History (3)

Changed February 12, 2009 11:31PM UTC by jzaefferer comment:1

milestone:	TBD → 1.6
priority:	minor → critical

I consider this critical. The focused close button is annoying me all the time, as it doesn't have a seperate hover-style and looks broken.

Changed February 13, 2009 03:01AM UTC by scottgonzalez comment:2

owner:	→ scott.gonzalez
status:	new → accepted

This has already been fixed in r1658 for dialogs that contain tabbable elements in the content area or have buttons.

Changed February 13, 2009 03:09AM UTC by scottgonzalez comment:3

resolution:	→ fixed
status:	accepted → closed

Fixed in r2068.

NOTE: This breaks accessibility in Safari, which doesn't allow setting focus on elements that are not natively tabbable. However, our current stance is that people who require accessibility will not be using Safari specifically for this type of reason.