#4182 closed bug (fixed)

Opened February 19, 2009 04:35AM UTC

Closed February 21, 2009 11:40AM UTC

slider min/max classes aren't being added to range div

Reported by: scottjehl Owned by: rdworth
Priority: critical Milestone: 1.7
Component: ui.slider Version: 1.6rc6
Keywords: Cc:
Blocked by: Blocking:
Description

the ui-slider-range-max class is not being added to the ui-slider-range div. Same for the ui-slider-range-min class. Instead, the styles are being set inline. Only the styles that need computing based on value should be set inline.

The CSS is already designed to support these classes.

Attachments (0)
Change History (5)

Changed February 19, 2009 04:36AM UTC by scottjehl comment:1

owner: → rdworth
status: new → assigned

Changed February 19, 2009 04:43AM UTC by scottjehl comment:2

description: the ui-slider-range-max class is not being added to the ui-slider-range div. Same for the ui-slider-range-min class. Instead, the styles are being set inline. Only the styles that need computing based on value should be set inline. \ \ The CSS is already designed to support these classes. → the ui-slider-range-max class is not being added to the ui-slider-range div. Same for the ui-slider-range-min class. Instead, the styles are being set inline. Only the styles that need computing based on value should be set inline. \ \ The CSS is already designed to support these classes. \ \
priority: major → critical

This is actually the cause of the Opera bug too.

From my testing, it appears the change discussed a while back where we'd remove the unnecessary value in min and max has not been implemented.

For example, in a horizontal slider max range, the left value should never be set inline. Only a width - nothing else. The css already has right: 0.

This should be true of all slider min/max ranges, respectively.

I closed bug 3850 and assigned this to rdworth.

Changed February 19, 2009 04:45AM UTC by scottjehl comment:3

Note that our static demo pages for min and max have this class and inline css properly applied.

trunk/tests/static/slider/slider_horizontal_range_max.html

trunk/tests/static/slider/slider_horizontal_range_min.html

same for vertical

Changed February 20, 2009 11:46AM UTC by rdworth comment:4

milestone: TBD → 1.6

Changed February 21, 2009 11:40AM UTC by rdworth comment:5

resolution: → fixed
status: assigned → closed

Fixed in r2118.