#4267 closed bug (notabug)

Opened March 03, 2009 12:11AM UTC

Closed August 11, 2009 07:15PM UTC

Last modified January 17, 2010 06:07AM UTC

Accordion height problems under a varierty of conditions

Reported by: Thaddeus Owned by:
Priority: major Milestone: 1.8
Component: ui.accordion Version: 1.6rc6
Keywords: Cc:
Blocked by: Blocking:
Description

I logged this earlier, but it got tagged as ui.core, which the link to report on is broken. Now correctly logged.

Autoheight works and fillspace works - on intialization, but adding more items changes the overall size, thus overflowing the container div that has an absolute height. I have 8 items in my accordion .

I tried to use the clearstyle option with fillspace hoping the height would dynamically reset itself, but it seems to trigger the fillspace first, then clears the style after... so fillspace flickers on, then ends up getting ignored. I think it should do the opposite. Clearstyle then set fillspace.

the sizing of this plugin (in 1.6) seems difficult to set and/or maintain.

Attachments (1)
  • accordionbug.html (3.7 KB) - added by Thaddeus March 03, 2009 12:54AM UTC.

    Sample height problem

Change History (5)

Changed March 03, 2009 12:58AM UTC by Thaddeus comment:1

Replying to [ticket:4267 Thaddeus]:

I logged this earlier, but it got tagged as ui.core, which the link to report on is broken. Now correctly logged. Autoheight works and fillspace works - on intialization, but adding more items changes the overall size, thus overflowing the container div that has an absolute height. I have 8 items in my accordion . I tried to use the clearstyle option with fillspace hoping the height would dynamically reset itself, but it seems to trigger the fillspace first, then clears the style after... so fillspace flickers on, then ends up getting ignored. I think it should do the opposite. Clearstyle then set fillspace. the sizing of this plugin (in 1.6) seems difficult to set and/or maintain.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.0.6) Gecko/2009011912 Firefox/3.0.6

Changed March 16, 2009 11:55PM UTC by trip comment:2

After doing some investigation, on the fillSpace option, it looks like the accordion spills below the container divs bottom position of 0 because there's a top-margin setting of 1px (found in the theme roller css file). The top-margin setting is required to create a space between each of the panels. So for each panel in the accordion; 1 px will overflow.... This can be fixed by changing the bottom position of the container div from 0px; to 8px; or rather whatever number of panels you happen to have in your accordion. This doesn't solve the problem completely since dynamically adding new panels or 'zooming' via the browser will still cause incremental spillover. I would suggest the plugin should be changed so that the fillpace sizing accounts for the number of panels.

Changed March 18, 2009 10:40AM UTC by rdworth comment:3

milestone: TBD → 1.8

Changed August 06, 2009 07:08PM UTC by jzaefferer comment:4

Using .resize() after changing the accordion content could fix the issue, but in case content should shrink, wouldn't work. For that .resize() would have to remove previous inline-heights first.

Changed August 11, 2009 07:15PM UTC by jzaefferer comment:5

resolution: → invalid
status: new → closed

Unable to reproduce this based on http://jquery-ui.googlecode.com/svn/trunk/tests/visual/accordion/accordion_option_fillSpace_true.html

May be partially fixed by #4695, which still leaves some issues unresolved.

Please reopen with a testpage based on 1.7.2 or 1.8.x.