Skip to main content

Search and Top Navigation

#4282 closed bug (fixed)

Opened March 06, 2009 06:19AM UTC

Closed May 11, 2009 12:33PM UTC

Droppable changes options object

Reported by: d.wachss Owned by:
Priority: critical Milestone: 1.8
Component: ui.droppable Version: 1.6rc6
Keywords: Cc:
Blocked by: Blocking:
Description

based on this discussion

http://groups.google.com/group/jquery-ui-dev/browse_thread/thread/abf6a10a8af2cac7

Droppable shouldn't modify the accept option, but should add a key to the widget object itself.

Change line 23 from

this.options.accept = accept && $.isFunction(accept) ? accept : function(d) {

to

this.accept = $.isFunction(accept) ? accept : function(d) {

and line 53 from

this.options.accept = value && $.isFunction(value) ? value : function(d) {

to

this.accept = $.isFunction(value) ? value : function(d) {

(I also removed the unnecessary guard expressions)

and change all the this.options.accept.call expressions to this.accept.call

Attachments (1)
  • ui.droppable.js.patch (3.6 KB) - added by ThrushAAX April 17, 2009 06:34PM UTC.

    complete tested fix starting from the ticket description

Change History (2)

Changed March 25, 2009 05:08PM UTC by scottgonzalez comment:1

milestone: TBD1.8
priority: minorcritical

Changed May 11, 2009 12:33PM UTC by jzaefferer comment:2

resolution: → fixed
status: newclosed

Applied in r2517, fixes 14 tests. Thanks for the contribution!