Ticket #4391 (closed bug: fixed)

Opened 6 years ago

Last modified 5 years ago

ui-state-hover, ui-state-active and disabled sliders

Reported by: vitch Owned by:
Priority: critical Milestone: 1.7.2
Component: ui.slider Version: 1.7.1
Keywords: Cc:
Blocking: Blocked by:

Description

When hovering over a ui-slider which has been disabled ui-state-hover shouldn't be applied. This corresponds to the behaviour of native HTML form controls when disabled.

Additionally, you can still currently tab to the handle in a disabled slider (although you can't move it). When you tab to it it gets ui-state-active applied. You shouldn't be able to tab to it (so the behaviour is the same as disabled form controls).

Attachments

ui.slider.4391.diff Download (905 bytes) - added by vitch 6 years ago.

Change History

comment:1 Changed 6 years ago by scott.gonzalez

Functional specs should be updated as well.

Changed 6 years ago by vitch

comment:2 Changed 6 years ago by vitch

Added simple patch.

comment:3 Changed 6 years ago by Cloudream

$(".ui-state-focus",this).removeClass('ui-state-focus');

vs

$(".ui-slider .ui-state-focus").removeClass('ui-state-focus');

Remove class from this slider's? Or all sliders' on the page?

comment:4 Changed 5 years ago by scott.gonzalez

  • Milestone changed from TBD to 1.8

comment:6 Changed 5 years ago by rdworth

  • Priority changed from minor to critical
  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r2430

comment:7 Changed 5 years ago by rdworth

  • Milestone changed from 1.8 to 1.7.2
Note: See TracTickets for help on using tickets.