#4443 closed bug (fixed)

Opened April 07, 2009 10:36AM UTC

Closed February 09, 2010 04:10AM UTC

Datepicker's vertical position in thickbox is wrong

Reported by: veronica Owned by:
Priority: minor Milestone: 1.8
Component: ui.datepicker Version: 1.7.1
Keywords: Cc:
Blocked by: Blocking:
Description

I inserted the text field and use datepicker in the thickbox. When I click the icon, the datepicker popups but in the wrong position.

The horizontal position (the value of the style "left") is correct, but the vertical position (the value of the style "TOP") is wrong.

I tried to modify the code in 1.7.1 even 1.6rc5 but are failed.

The original code is:

var viewHeight = (window.innerHeight || document.documentElement.clientHeight || 
document.body.clientHeight) + $(document).scrollTop();

and my modified code is:

var viewHeight = (window.innerHeight || document.documentElement.clientHeight || 
document.body.clientHeight) + $(document.documentElement).scrollTop();

The vertical position increased but not enough, the top values in my website now are as follows:

TOP: 467px (in IE7)

TOP: 507px (in Firefox3)

TOP: 724px (the correct value in Firefox3, tested by Firebug.)

I guess maybe something wrong when calculate height.

Thanks in advance.

Attachments (3)
  • correct.2.jpg (25.3 KB) - added by veronica April 07, 2009 10:39AM UTC.

    The datepicker in Firefox after modified the jquery.ui.js code

  • correct.jpg (25.3 KB) - added by veronica April 07, 2009 10:38AM UTC.

    The datepicker in the correct position after modified the style's "top" attribute by firebug.

  • firefox.jpg (24.7 KB) - added by veronica April 07, 2009 10:36AM UTC.

    The datepicker in Firefox before modified the jquery.ui.js code

Change History (2)

Changed April 08, 2009 01:43AM UTC by scottgonzalez comment:1

milestone: TBD → 1.8

Changed February 09, 2010 04:10AM UTC by caphun comment:2

resolution: → fixed
status: new → closed

Fixed in r3792