Ticket #4443 (closed bug: fixed)

Opened 6 years ago

Last modified 5 years ago

Datepicker's vertical position in thickbox is wrong

Reported by: veronica Owned by:
Priority: minor Milestone: 1.8
Component: ui.datepicker Version: 1.7.1
Keywords: Cc:
Blocking: Blocked by:

Description

I inserted the text field and use datepicker in the thickbox. When I click the icon, the datepicker popups but in the wrong position.

The horizontal position (the value of the style "left") is correct, but the vertical position (the value of the style "TOP") is wrong.

I tried to modify the code in 1.7.1 even 1.6rc5 but are failed. The original code is:

var viewHeight = (window.innerHeight || document.documentElement.clientHeight || 
document.body.clientHeight) + $(document).scrollTop();

and my modified code is:

var viewHeight = (window.innerHeight || document.documentElement.clientHeight || 
document.body.clientHeight) + $(document.documentElement).scrollTop();

The vertical position increased but not enough, the top values in my website now are as follows:

TOP: 467px (in IE7)
TOP: 507px (in Firefox3)
TOP: 724px (the correct value in Firefox3, tested by Firebug.)

I guess maybe something wrong when calculate height.

Thanks in advance.

Attachments

firefox.jpg Download (24.7 KB) - added by veronica 6 years ago.
The datepicker in Firefox before modified the jquery.ui.js code
correct.jpg Download (25.3 KB) - added by veronica 6 years ago.
The datepicker in the correct position after modified the style's "top" attribute by firebug.
correct.2.jpg Download (25.3 KB) - added by veronica 6 years ago.
The datepicker in Firefox after modified the jquery.ui.js code

Change History

Changed 6 years ago by veronica

The datepicker in Firefox before modified the jquery.ui.js code

Changed 6 years ago by veronica

The datepicker in the correct position after modified the style's "top" attribute by firebug.

Changed 6 years ago by veronica

The datepicker in Firefox after modified the jquery.ui.js code

comment:1 Changed 6 years ago by scott.gonzalez

  • Milestone changed from TBD to 1.8

comment:2 Changed 5 years ago by caphun

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r3792

Note: See TracTickets for help on using tickets.