Ticket #4501 (closed enhancement: fixed)

Opened 6 years ago

Last modified 5 years ago

Tabs should work with ordered lists (<ol>) in addition to unordered (<ul>)

Reported by: BenBlank Owned by:
Priority: minor Milestone: 1.8
Component: ui.tabs Version: 1.7.1
Keywords: tabs,ol,ordered,list Cc:
Blocking: Blocked by:

Description

Currently, the tabs component will only read "tabbing" links from unordered lists. As ordered lists use identical structure, this seems like an unnecessary restriction.

Use case: I am currently building a tabbed interface which represents a multi-step application process. The steps (and tabs) are prominently displayed as "1. Getting Started", "2. Personal Info", etc., and the tabbing links have accelerator keys of 1, 2, etc. Clearly, the tabs semantically represent an ordered list, but using one prevents the use of the tabs component.

Find attached a simple patch against ui.tabs.js which will cause the tabs component to use the first list in the target element, regardless of whether it is ordered or unordered.

Attachments

ui.tabs.js@r2500-ol.diff Download (460 bytes) - added by BenBlank 6 years ago.

Change History

Changed 6 years ago by BenBlank

comment:1 Changed 5 years ago by joern.zaefferer

  • Milestone changed from TBD to 1.8

Related to #4506.

comment:2 Changed 5 years ago by scott.gonzalez

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r3421. The first descendant list found will be used now.

Note: See TracTickets for help on using tickets.