Skip to main content

Search and Top Navigation

#4501 closed enhancement (fixed)

Opened April 28, 2009 09:03PM UTC

Closed November 09, 2009 02:37AM UTC

Tabs should work with ordered lists (<ol>) in addition to unordered (<ul>)

Reported by: BenBlank Owned by:
Priority: minor Milestone: 1.8
Component: ui.tabs Version: 1.7.1
Keywords: tabs,ol,ordered,list Cc:
Blocked by: Blocking:
Description

Currently, the tabs component will only read "tabbing" links from unordered lists. As ordered lists use identical structure, this seems like an unnecessary restriction.

Use case: I am currently building a tabbed interface which represents a multi-step application process. The steps (and tabs) are prominently displayed as "1. Getting Started", "2. Personal Info", etc., and the tabbing links have accelerator keys of 1, 2, etc. Clearly, the tabs semantically represent an ordered list, but using one prevents the use of the tabs component.

Find attached a simple patch against [source:/trunk/ui/ui.tabs.js@2500 ui.tabs.js] which will cause the tabs component to use the first list in the target element, regardless of whether it is ordered or unordered.

Attachments (1)
Change History (2)

Changed May 07, 2009 01:09PM UTC by jzaefferer comment:1

milestone: TBD1.8

Related to #4506.

Changed November 09, 2009 02:37AM UTC by scottgonzalez comment:2

resolution: → fixed
status: newclosed

Fixed in r3421. The first descendant list found will be used now.