Ticket #4551 (closed bug: notabug)

Opened 5 years ago

Last modified 2 years ago

Sortable connectWith fails if item is floated

Reported by: dhlavaty Owned by:
Priority: critical Milestone:
Component: ui.sortable Version: 1.7.1
Keywords: float connectwith Cc:
Blocking: Blocked by:

Description

Connecting one sortable to another not working if item is floated (like in 'Display as Grid' demo).

It is working only in IE7. But not working in Firefox, Chrome, Opera.

Attachments

connectWith-and-float-bug.html Download (1.4 KB) - added by dhlavaty 5 years ago.
connectWith and float bug works only in IE
patch.txt Download (564 bytes) - added by jlillywhite 5 years ago.
This seems to resolve the issue in Firefox and Chrome.

Change History

Changed 5 years ago by dhlavaty

connectWith and float bug works only in IE

comment:1 Changed 5 years ago by rdworth

  • Priority changed from blocker to critical
  • Milestone changed from 1.7.2 to 1.8

Changed 5 years ago by jlillywhite

This seems to resolve the issue in Firefox and Chrome.

comment:2 Changed 5 years ago by rdworth

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r2882

comment:3 Changed 3 years ago by scribu

FYI: This caused some issues downstream:

 http://core.trac.wordpress.org/ticket/16955

comment:4 Changed 3 years ago by rdworth

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Milestone 1.8 deleted

It turns out this test case was invalid. The sortable items had float:left but the sortable containers did not, giving them no height. The fix is a css one, set float:left on the sortable containers as well as the sortable items.

comment:5 Changed 3 years ago by rdworth

Reverted from master (1.9pre) in  54016b8

comment:6 Changed 3 years ago by rdworth

  • Status changed from reopened to closed
  • Resolution set to invalid

Reverted from 1-8-stable in  c205fbc

comment:7 Changed 2 years ago by uacode

change: float: left to display: inline-block

Note: See TracTickets for help on using tickets.