#4627 closed bug (fixed)

Opened June 23, 2009 01:51PM UTC

Closed March 05, 2010 04:44AM UTC

themeroller bookmarklet conflicts with page scripts

Reported by: scottjehl Owned by:
Priority: critical Milestone: 1.8
Component: [meta] ui.themeroller Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:
Description

The TR bookmarklet injects jQuery and UI when it loads, overriding any customizations done to jQuery already on the page. These need to run without conflicting with the page.

Attachments (0)
Change History (4)

Changed July 09, 2009 02:03PM UTC by jzaefferer comment:1

Using $.noConflict is should be possible to load both jQuery and jQuery UI and still keep everything on the page intact. The pattern should be:

// store old references, maybe just "old = jQuery"?
var old = $.noConflict(true);
// load jQuery and jQuery UI, initialize themeroller
...
// restore old references
$ = jQuery = old;

Changed July 09, 2009 02:03PM UTC by jzaefferer comment:2

milestone: TBD → 1.8

Changed July 09, 2009 05:42PM UTC by scottgonzalez comment:3

Actually, you can load jQuery and jQuery UI, store a reference to jQuery, then call $.noConflict(true) and it'll restore the old references for you.

Changed March 05, 2010 04:44AM UTC by mikehostetler comment:4

resolution: → fixed
status: new → closed