Ticket #4664 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

uiDialog.resizable needs containment:'document' to agree with uiDialog.draggable.

Reported by: audreyt Owned by:
Priority: minor Milestone: 1.8
Component: ui.dialog Version: 1.7.2
Keywords: Cc:
Blocking: Blocked by:

Description

As users can't drag a dialog outside the document range, they shouldn't be able to resize a dialog outside the document range either.

This was reported by Tracy Ruggles at Socialtext and fixed by yours truly -- patch follows.

--- jquery-ui-1.7.2.custom.js +++ jquery-ui-1.7.2.custom.js @@ -2422,6 +2422,7 @@ $.widget("ui.dialog", {

this.uiDialog.resizable({

cancel: '.ui-dialog-content',

+ containment: 'document',

alsoResize: this.element, maxWidth: options.maxWidth, maxHeight: options.maxHeight,

Change History

comment:1 Changed 5 years ago by audreyt

Er, sorry, here is the patch again.

--- jquery-ui-1.7.2.custom.js
+++ jquery-ui-1.7.2.custom.js
@@ -2422,6 +2422,7 @@ $.widget("ui.dialog", {
 
                this.uiDialog.resizable({
                        cancel: '.ui-dialog-content',
+                       containment: 'document', // XXX - ST Local modification to fix {bz: 2807} - AudreyT
                        alsoResize: this.element,
                        maxWidth: options.maxWidth,
                        maxHeight: options.maxHeight,

comment:2 Changed 5 years ago by scott.gonzalez

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from TBD to 1.8

Fixed in r2950. Thanks.

Note: See TracTickets for help on using tickets.