#4664 closed bug (fixed)

Opened July 10, 2009 11:41AM UTC

Closed July 21, 2009 12:05AM UTC

uiDialog.resizable needs containment:'document' to agree with uiDialog.draggable.

Reported by: audreyt Owned by:
Priority: minor Milestone: 1.8
Component: ui.dialog Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:
Description

As users can't drag a dialog outside the document range, they shouldn't be able to resize a dialog outside the document range either.

This was reported by Tracy Ruggles at Socialtext and fixed by yours truly -- patch follows.

--- jquery-ui-1.7.2.custom.js

+++ jquery-ui-1.7.2.custom.js

@@ -2422,6 +2422,7 @@ $.widget("ui.dialog", {

this.uiDialog.resizable({

cancel: '.ui-dialog-content',

+ containment: 'document',

alsoResize: this.element,

maxWidth: options.maxWidth,

maxHeight: options.maxHeight,

Attachments (0)
Change History (2)

Changed July 10, 2009 11:42AM UTC by audreyt comment:1

Er, sorry, here is the patch again.

--- jquery-ui-1.7.2.custom.js
+++ jquery-ui-1.7.2.custom.js
@@ -2422,6 +2422,7 @@ $.widget("ui.dialog", {
 
                this.uiDialog.resizable({
                        cancel: '.ui-dialog-content',
+                       containment: 'document', // XXX - ST Local modification to fix {bz: 2807} - AudreyT
                        alsoResize: this.element,
                        maxWidth: options.maxWidth,
                        maxHeight: options.maxHeight,

Changed July 21, 2009 12:05AM UTC by scottgonzalez comment:2

milestone: TBD → 1.8
resolution: → fixed
status: new → closed

Fixed in r2950. Thanks.