#4714 closed feature (wontfix)

Opened July 24, 2009 03:23PM UTC

Closed October 04, 2012 05:29PM UTC

Themeswitcher: onSelect behavior

Reported by: pwnedd Owned by:
Priority: minor Milestone: 1.10.0
Component: [meta] ui.themeroller Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:
Description

Would it be possible to:

1. Have onSelect provide the name of the theme that was selected? It is not hard to find (e.g. $(".jquery-ui-themeswitcher-trigger > .jquery-ui-themeswitcher-title").text()), but it would be useful to simply pass to the event-handler.

2. Prevent onSelect from firing during initialization?

Thanks,

Keith

Attachments (0)
Change History (5)

Changed November 17, 2009 06:15PM UTC by jzaefferer comment:1

milestone: TBD → 1.next

Changed May 21, 2011 12:58AM UTC by Lwangaman comment:2

Not sure about point 1, but if I understand correctly point 2 it's an issue I've been thinking about lately. When setting the "onSelect" callback in the widget options, I noticed that it was getting triggered on every page load after having selected a theme. I believe that the expected behaviour is to trigger only after the actual select from the widget, and not on every successive theme load (such as on page load).

I found the cause, it was because when the theme is loaded either from the cookie or from the "loadTheme" option, a click is triggered on the widget, causing the onselect event to trigger also. So I deleted the click trigger and modified it so as not to trigger the onselect event. Here is my test case on jsbin:

http://jsbin.com/ehoja3/9 ( = original themeswitcher widget code)

versus

http://jsbin.com/ehoja3/8 (my code)

Is the themeswitcher widget to be found on the repository on GitHub? If so I can push a fix, but after looking over the repository I could not find the themeswitcher widget code.

Changed June 26, 2012 01:22AM UTC by scottgonzalez comment:3

type: enhancement → feature

Changed October 03, 2012 04:57PM UTC by scottgonzalez comment:4

milestone: 1.next → 1.10.0

Changed October 04, 2012 05:29PM UTC by scottgonzalez comment:5

resolution: → wontfix
status: new → closed

We're no longer supporting ThemeSwitcher. Please use Dave Hoff's Super Theme Switcher.