Ticket #4972 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

border-radius support

Reported by: dantman Owned by:
Priority: critical Milestone: 1.8
Component: ui.css-framework Version: 1.8a1
Keywords: Cc:
Blocking: Blocked by:

Description

jQuery UI border-radius support is incomplete: The current ui.theme.css only uses -moz and -webkit vendor extensions.

border-radius has been implemented in 4 different rendering engines:

-moz-border-radius: (Gecko; Firefox, etc...)
-webkit-border-radius: (WebKit; Safari, Chrome)
-khtml-border-radius: (Formerly WebKit, KHTML; Konqueror)
border-radius: (IE9; W3 Draft standard)

The only browser that has not implemented border radius yet is Opera, and the devs have stated when/if they do get to the feature they will implement it either using -o-border-radius or the standard border-radius. Though considering the approaching state of the draft we probably won't need to worry about -o-border-radius:;.

The  last call for comments on border-radius is already passed, and none of them are relevant to the format of the property as jQuery UI is using them. The draft will likely become a candidate recommendation around Christmas and it's already past the point where any changes will be made that could affect how jQuery UI is using border-radius.

Early fixing is fairly important, normally when people use libraries they download the library, develop with it, but don't go back to upgrade for awhile. If jQuery UI delays all the way till a browser has been released stable with support and the w3 draft has reached candidate recommendation there's likely going to be a fair bit of lag where a large portion of jQuery UI using sites don't support radius in all the browsers, even when they have it implemented. Wikimedia is using jQuery UI in the js2 system in their UsabilityInitiative which will be included in the upcoming 1.16 release of MediaWiki. I'd hate to see what would happen if MediaWiki 1.16 was released before jQuery UI released full and forward border-radius compatibility. It would be at least another half year before another release of MW comes out with that support, and a deal of time after that before most installations get to upgrading from 1.16;


So in summary, jQuery UI's use of border-radius is missing support for one browser, and is not forward compatible with IE9 and the approaching standard. The properties that should be added are border-radius:; and -khtml-border-radius:;

Change History

comment:1 Changed 4 years ago by scott.gonzalez

  • Milestone changed from TBD to 1.8

I really don't think we should be adding border-radius ahead of time. Nothing is ever guaranteed to become a standard.

comment:2 Changed 4 years ago by dantman

What about support for IE9, and the missing support for KHTML?

comment:4 Changed 4 years ago by scott.gonzalez

  • Priority changed from minor to critical

comment:5 Changed 4 years ago by scott.gonzalez

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r3735.

Note: See TracTickets for help on using tickets.