Ticket #5178 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Slider's change event fires on slide

Reported by: vmx Owned by:
Priority: blocker Milestone: 1.8
Component: ui.slider Version: 1.8rc1
Keywords: Cc:
Blocking: Blocked by:

Description

When you attach a callback to the sliders "change" event (.slider({change: function() {/*idosomething*/}});) it is called on every move of the slider, just like the "slide" event. It's not the expected behaviour that it only fires when the value changed.

It's a regression, it works in UI 1.7.2.

To see the problem, replace the "slide" callback in the steps demo with "change".

Attachments

ui-slider-change.patch Download (1.1 KB) - added by vmx 5 years ago.
Don't fire change event on slide

Change History

Changed 5 years ago by vmx

Don't fire change event on slide

comment:1 Changed 5 years ago by vmx

Please have a look at the patch. Though I'm not really happy with it, as it is more of a hack than a fix.

comment:2 Changed 5 years ago by scott.gonzalez

  • Priority changed from critical to blocker

comment:3 Changed 5 years ago by rdworth

regression occurred is r3361

comment:4 Changed 5 years ago by rdworth

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r3800

Note: See TracTickets for help on using tickets.