Search and Top Navigation
#5313 closed bug (worksforme)
Opened March 09, 2010 04:11PM UTC
Closed March 27, 2010 12:07AM UTC
Modal Dialog's background shadow disappears in Firefox when page scrolls
| Reported by: | LiamD | Owned by: | |
|---|---|---|---|
| Priority: | critical | Milestone: | 1.9.0 |
| Component: | ui.dialog | Version: | 1.8rc3 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
I have a page that uses the UI dialog in version 1.8rc3. The page scrolls a bit and in IE 8 and chrome the background shadow fills the entire page but in Firefox 3.6 (latest) it only fills the top part of the page. I saw the previous ticket on this (#4995) and that it is to be fixed for 1.8. I was wondering if you were aware of the issue in Firefox and if so is it still scheduled for the 1.8 milestone? In the meantime is there a workaround for this?
Attachments (0)
Change History (3)
Changed March 09, 2010 04:44PM UTC by comment:1
Changed March 10, 2010 05:35PM UTC by comment:2
| milestone: | TBD → 1.8 |
|---|---|
| priority: | major → critical |
Changed March 27, 2010 12:07AM UTC by comment:3
| resolution: | → worksforme |
|---|---|
| status: | new → closed |
This is working fine for me. Please attach a page showing the problem.
fixed this myself locally. In the 1.8rc file circa line 5930 there is the following function for calculating the height of the background shadow.
height: function() {
.....
else {
return $(document).height() + 'px';
}
This was returning the height of the visible content in firefox. I changed it to be
if($.browser.mozilla)
{
var scrollHeight = Math.max(
document.documentElement.scrollHeight,
$(document).height()
);
return scrollHeight + 'px';
}
else
{
return $(document).height() + 'px';
}
Think this fix should be ok as it should test for scroll height and which ever is max it will take as the height of the background. works for me any way!