#5392 closed bug (fixed)

Opened March 21, 2010 04:54PM UTC

Closed March 26, 2010 01:59AM UTC

Last modified May 10, 2010 07:14PM UTC

Dialog explicit height doesn't match given value from set option

Reported by: Rwhitbeck Owned by:
Priority: blocker Milestone: 1.8.1
Component: ui.dialog Version: 1.8
Keywords: Cc:
Blocked by: Blocking:
Description

While trying to figure out some of the failing unit tests I came across a failed test that needs to be looked at.

When setting dialogs height explicitly the actual height is 18 pixels higher then specified.

Test case http://jsbin.com/equce/edit

Forum: http://forum.jquery.com/topic/dialog-explicit-height-doesn-t-match-given-value-from-set-option

Attachments (0)
Change History (7)

Changed March 21, 2010 04:55PM UTC by Rwhitbeck comment:1

description: While trying to figure out some of the failing unit tests I came across a failed test that needs to be looked at. \ \ When setting dialogs height explicitly the actual height is 18 pixels higher then specified. \ \ Test case http://jsbin.com/equce → While trying to figure out some of the failing unit tests I came across a failed test that needs to be looked at. \ \ When setting dialogs height explicitly the actual height is 18 pixels higher then specified. \ \ Test case http://jsbin.com/equce \ \ Forum: http://forum.jquery.com/topic/dialog-explicit-height-doesn-t-match-given-value-from-set-option

Changed March 21, 2010 06:07PM UTC by Rwhitbeck comment:2

description: While trying to figure out some of the failing unit tests I came across a failed test that needs to be looked at. \ \ When setting dialogs height explicitly the actual height is 18 pixels higher then specified. \ \ Test case http://jsbin.com/equce \ \ Forum: http://forum.jquery.com/topic/dialog-explicit-height-doesn-t-match-given-value-from-set-option → While trying to figure out some of the failing unit tests I came across a failed test that needs to be looked at. \ \ When setting dialogs height explicitly the actual height is 18 pixels higher then specified. \ \ Test case http://jsbin.com/equce/edit \ \ Forum: http://forum.jquery.com/topic/dialog-explicit-height-doesn-t-match-given-value-from-set-option

Changed March 21, 2010 08:31PM UTC by jzaefferer comment:3

The dialog unit tests actually cover that (and are failing due to the issue).

Changed March 22, 2010 04:17AM UTC by Rwhitbeck comment:4

Right that's what I am saying. The unit test failed and when I went to see why I discovered the annomoly ;)

Changed March 22, 2010 11:56AM UTC by scottgonzalez comment:5

Partial fix in 596d1ef581379d35104e2eb466797b5d89cc6f1a.

Changed March 26, 2010 01:59AM UTC by scottgonzalez comment:6

resolution: → fixed
status: new → closed

Fixed in b297b3fa6a1e4b6cba735a10ca03a6175f8eda3a.

Changed April 21, 2010 01:18PM UTC by rdworth comment:7

milestone: 1.9 → 1.8.1