#5394 closed bug (notabug)

Opened March 21, 2010 07:06PM UTC

Closed February 24, 2012 11:52AM UTC

Last modified February 24, 2012 12:21PM UTC

Tests: Reproduce ticket-specific visual tests in unit tests where possible

Reported by: jzaefferer Owned by:
Priority: major Milestone: 1.9.0
Component: [meta] ui.test Version: 1.8
Keywords: Cc:
Blocked by: Blocking:
Description

Put them in [plugin]_tickets.js.

Attachments (0)
Change History (2)

Changed February 24, 2012 11:52AM UTC by jzaefferer comment:1

resolution: → invalid
status: new → closed

Should track that individually, if at all. Ticket specific tests are silly anyway.

Changed February 24, 2012 12:21PM UTC by scottgonzalez comment:2

We generally track suite-wide changes in single tickets, especially when they don't result in any API changes.

For this specific issue, the general idea is still valid, though the suggestion is not. We shouldn't have ticket-specific tests, but we should make sure that we're moving visual tests to unit tests as much as possible.

It's also not good to close a generic ticket in favor of specific tickets without the specific tickets already existing, since the reminder (ticket) is now off of our radar. In this case, we've got the visual test page cleanup wiki page and it's on the roadmap, so I'm fine with the ticket being closed (though I don't think it's invalid).