Ticket #5576 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

invalid increment operand

Reported by: joernroeder Owned by:
Priority: blocker Milestone: 1.8.2
Component: [meta] ui.build Version: 1.8.1
Keywords: Cc:
Blocking: Blocked by:

Description

I get an invalid increment operand error when i minimize the code.

Change History

comment:1 Changed 5 years ago by joernroeder

i looked at the code and it looks as if it was already fixed. you can close this ticked.

comment:2 Changed 5 years ago by nyro

This bug reappears in the 1.8.1 release

The code mentioned here  http://dev.jqueryui.com/ticket/3434 is reused in 4 different places in the jQuery UI code. Just search for "+ ++" and you'll find it.

wrapping the second ++var with parentheses seems to fix the problem.

comment:3 Changed 5 years ago by scott.gonzalez

  • Priority changed from major to blocker
  • Component changed from ui.tabs to [meta] ui.build
  • Milestone changed from TBD to 1.9

comment:4 Changed 5 years ago by Rwhitbeck

@joernroeder - you say you are minimizing the code. Can you be specific and let us know exactly what you are doing?

Thanks

comment:5 Changed 5 years ago by rdworth

Fix for Datepicker in  0ad5ac7. Fix still needed for Tabs.

comment:6 Changed 5 years ago by nyro

@Rwhitbeck I experienced the same problem by simply downloading jQuery UI 1.8.1 from the main page. The minified version was already done on the zip.

comment:7 Changed 5 years ago by rdworth

@nyro We haven't been able to reproduce with the version in the zip or either of these versions

 http://jquery-ui.googlecode.com/svn/tags/1.8.1/ui/minified/jquery-ui.min.js

 http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.1/jquery-ui.min.js

Can you post a sample page or reproduce on  http://jsbin.com/ ? Thanks.

comment:8 Changed 5 years ago by nyro

@rdworth: after checking again and some testing, it looks it might be related to the minifier engine I'm using.

I created a demo page with everything explained:  http://temp.nyro.com/jqueryUIBug5576/

As I said, it might be related to MoxieCompressor. I didn't test with another tool and I will check for an other engine.

comment:9 Changed 5 years ago by nyro

BTW, if we look here:  http://www.crockford.com/javascript/jsmin.html in the Caution section, there is an explanation about the problem.

comment:10 Changed 5 years ago by scott.gonzalez

  • Status changed from new to closed
  • Resolution set to fixed

Tabs fixed in  fcbf4c0.

comment:11 Changed 5 years ago by rdworth

  • Milestone changed from 1.9 to 1.8.2
Note: See TracTickets for help on using tickets.