Ticket #5581 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

_setOption being called with 'self' rather than 'this'

Reported by: jquery@… Owned by:
Priority: blocker Milestone: 1.8.2
Component: ui.sortable Version: 1.8.1
Keywords: Cc:
Blocking: Blocked by:

Description

In the _setOption method the following line appears:

$.Widget.prototype._setOption.apply(self, arguments); (line 3049 in the current full source code library)

Under some complex conditions in our code, self points to the window, not the sortable object. Changing 'self' to 'this' makes everything good.

Note: I haven't spent enough time in this code to be that this change is valid. If it's really required, maybe I can produce a test case that shows the problem, but at this point, the code is intertwined with a jquery.linkselect

Change History

comment:1 Changed 4 years ago by rdworth

  • Priority changed from major to blocker
  • Milestone changed from TBD to 1.9

comment:2 Changed 4 years ago by rdworth

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in  a4488af

comment:3 Changed 4 years ago by rdworth

  • Milestone changed from 1.9 to 1.8.2
Note: See TracTickets for help on using tickets.