Ticket #5607 (closed bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Selectable has helper css hardcoded in JS

Reported by: ajpiano Owned by:
Priority: major Milestone: 1.8.2
Component: ui.selectable Version: 1.8.1
Keywords: Cc:
Blocking: Blocked by:

Description (last modified by ajpiano) (diff)

Selectable applies a css style to the helper that should be applied by default in CSS.

Reported via twitter,  http://twitter.com/e1en0r/statuses/13833271710

Change History

comment:1 Changed 5 years ago by ajpiano

This betrays the underlying problem that interaction plugins don't have their own CSS, even though the docs say that they do.

comment:2 Changed 5 years ago by ajpiano

  • Description modified (diff)

I've created a possible fix for this, but it introduces a new file for the CSS framework.

 http://github.com/ajpiano/jquery-ui/commit/2039ee9d09ba12956ca811936d63e084691b165f

comment:3 follow-up: ↓ 4 Changed 5 years ago by ajpiano

This is the actual fix with the proper files included in the commit.

 http://github.com/ajpiano/jquery-ui/commit/01201a331e6e685ca4ac75b981df34fa4e4fbf65

comment:4 in reply to: ↑ 3 Changed 5 years ago by rdworth

Replying to ajpiano:

This is the actual fix with the proper files included in the commit.

 http://github.com/ajpiano/jquery-ui/commit/01201a331e6e685ca4ac75b981df34fa4e4fbf65

Commented on  GitHub. Two code changes and one commit message change needed. Otherwise, looking good. Thanks.

comment:5 Changed 5 years ago by rdworth

  • Milestone changed from TBD to 1.8.2

comment:6 Changed 4 years ago by rdworth

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in  05725e2

Note: See TracTickets for help on using tickets.