Skip to main content

Search and Top Navigation

#5607 closed bug (fixed)

Opened May 12, 2010 06:02AM UTC

Closed May 26, 2010 09:21PM UTC

Selectable has helper css hardcoded in JS

Reported by: ajpiano Owned by:
Priority: major Milestone: 1.8.2
Component: ui.selectable Version: 1.8.1
Keywords: Cc:
Blocked by: Blocking:
Description

Selectable applies a css style to the helper that should be applied by default in CSS.

Reported via twitter,

http://twitter.com/e1en0r/statuses/13833271710

Attachments (0)
Change History (6)

Changed May 12, 2010 06:13AM UTC by ajpiano comment:1

This betrays the underlying problem that interaction plugins don't have their own CSS, even though the docs say that they do.

Changed May 12, 2010 06:37AM UTC by ajpiano comment:2

description: Selectable applies a css style to the helper that should be applied by default in CSS. \ \ Reported via twitter, \ http://twitter.com/e1en0r/statuses/13833271710Selectable applies a css style to the helper that should be applied by default in CSS. \ \ Reported via twitter, \ http://twitter.com/e1en0r/statuses/13833271710 \ \

I've created a possible fix for this, but it introduces a new file for the CSS framework.

http://github.com/ajpiano/jquery-ui/commit/2039ee9d09ba12956ca811936d63e084691b165f

Changed May 12, 2010 02:09PM UTC by ajpiano comment:3

This is the actual fix with the proper files included in the commit.

http://github.com/ajpiano/jquery-ui/commit/01201a331e6e685ca4ac75b981df34fa4e4fbf65

Changed May 12, 2010 03:02PM UTC by rdworth comment:4

Replying to [comment:3 ajpiano]:

This is the actual fix with the proper files included in the commit. http://github.com/ajpiano/jquery-ui/commit/01201a331e6e685ca4ac75b981df34fa4e4fbf65

Commented on GitHub. Two code changes and one commit message change needed. Otherwise, looking good. Thanks.

Changed May 20, 2010 11:14AM UTC by rdworth comment:5

milestone: TBD1.8.2

Changed May 26, 2010 09:21PM UTC by rdworth comment:6

resolution: → fixed
status: newclosed

Fixed in 05725e2