#6185 closed feature (notabug)

Opened October 14, 2010 04:50PM UTC

Closed September 24, 2011 08:08AM UTC

Last modified October 11, 2012 09:15PM UTC

Dialog doesnt have ability to have custom buttons

Reported by: abhishekdev Owned by: abhishekdev
Priority: major Milestone:
Component: ui.dialog Version: 1.8.5
Keywords: Dialog Button Cc:
Blocked by: Blocking:
Description

I have custom icon buttons using <div> and dont want to use the default jQuery UI Dialog buttons. There is no way I can achive this by the dialog initialization commands.

Temporarily I am passing by buttons as content. Cloning them and replacing the jQuery Dialog buttons with them when the dialog opens

Bug 1: Event namespaces on the cloned buttons vanishes.

Bug 2: The resizing logic is based on the jQuery buttons height, rather than the actual contents height. (Workaround: Override the default button height with that of custom button)

Attachments (0)
Change History (8)

Changed September 06, 2011 06:58PM UTC by scottgonzalez comment:1

Can you explain why you don't want to use the button widget?

Changed September 06, 2011 10:26PM UTC by scottgonzalez comment:2

owner: → abhishekdev
status: new → pending

Changed September 07, 2011 02:58PM UTC by abhishekdev comment:3

status: pending → new

In the application i work on, we have custom styled iconized (size changes based on dialog type) buttons, and they have corresponding classes (JS Classes) to control their behavior. jQuery UI Buttons does not suffice for us. However jQuery UI Dialog with some custom styling has been suiting our needs well (if not all). We require to place buttons on left as well on right edge of the dialog. The button widget itself has so many styling (esp. V-align ) bugs due to the inherent nature of HTML elements it uses to structure itself.

What I think:

Dialog should give a choice to use jQuery UI Buttons OR custom markup (for the entire button bar). In the latter case the Dialog algo should just care about the sizing logic regarding the button bar (i.e during dialog resizes).

The current logic makes Dialog's good and simple but not customizable to work with components that have many more behaviors and style posiibilities than jQueryUI buttons.

Changed September 07, 2011 03:12PM UTC by scottgonzalez comment:4

What would the API look like? You can already inject whatever markup you want into the dialog after it's created and it will be accounted for when calculating the size.

Changed September 07, 2011 03:13PM UTC by scottgonzalez comment:5

Example of injecting a custom button pane: http://jsbin.com/adurim/edit#javascript,html

Changed September 09, 2011 04:44PM UTC by scottgonzalez comment:6

status: new → pending

Changed September 24, 2011 08:08AM UTC by trac-o-bot comment:7

resolution: → invalid
status: pending → closed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Changed October 11, 2012 09:15PM UTC by scottgonzalez comment:8

milestone: TBD

Milestone TBD deleted