Search and Top Navigation
#6763 closed bug (fixed)
Opened December 19, 2010 06:24PM UTC
Closed February 08, 2012 04:44PM UTC
Last modified February 08, 2012 04:47PM UTC
ui.dialog & resizable & button & opera 11
Reported by: | demimurych | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.8.18 |
Component: | ui.dialog | Version: | 1.8.7 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
Run opera 11
Go to http://jqueryui.com/demos/dialog/#modal-message
Try to resize dilog box
Look at button pane
Attachments (0)
Change History (8)
Changed June 26, 2011 07:55AM UTC by comment:1
Changed November 11, 2011 04:24PM UTC by comment:2
Created a minimal test case - http://jsfiddle.net/aKxgY/2/.
Changed December 21, 2011 10:22AM UTC by comment:3
Masking Opera as Firefox fixes this. This means that custom code is executed for Opera. I'm guessing this code in ui.resizable is responsible:
//Opera fix for relative positioning if (/relative/.test(this.element.css('position')) && $.browser.opera) this.element.css({ position: 'relative', top: 'auto', left: 'auto' });
Changed February 05, 2012 06:02PM UTC by comment:4
This is the code that specifically creates the issue (in _alsoResize within resize):
// Opera fixing relative position if ($.browser.opera && /relative/.test(el.css('position'))) { self._revertToRelativePosition = true; el.css({ position: 'absolute', top: 'auto', left: 'auto' }); }
In this instance it sets the .ui-dialog-content div to position: absolute which causes the layout issue. If that block is commented out this issue is fixed.
I'm wondering if anyone knows what the original hack for Opera was fixing? The only reference in the bug tracker to this I can find are #5694 & #5695 which are both fixes to the hack, and don't really explain what the hack was originally for. It appears to have been in there since the beginning of Git time and there aren't any unit tests for it.
If I remove the Opera hacks in their entirety all the demos work fine at least. Maybe this is a bug that Opera has fixed...?
Changed February 06, 2012 01:41PM UTC by comment:5
Thanks tj. I'm not sure what it was fixing either. Now that we only support Opera 11.5+, it should be safe to remove. Can you send a pull request?
Changed February 07, 2012 02:26AM UTC by comment:6
Pull request - https://github.com/jquery/jquery-ui/pull/593
Changed February 08, 2012 04:44PM UTC by comment:7
resolution: | → fixed |
---|---|
status: | new → closed |
Fixed in f5e5971821dab4caf03dae4a6d207429aef44bae.
Changed February 08, 2012 04:47PM UTC by comment:8
milestone: | 1.9 → 1.8.18 |
---|
Fixed in 1-8-stable in 28fb436b7b75de01cc1caf3132f56381b6c7c190.
I have a screencast for this bug:
https://scienceco.de/~levu/dialog_opera_button.ogv