Search and Top Navigation
#7257 closed enhancement (fixed)
Opened April 15, 2011 02:49PM UTC
Closed April 29, 2011 12:24PM UTC
Last modified July 30, 2011 11:50AM UTC
Core: optimize :tabbable
| Reported by: | adambaratz | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.9.0 |
| Component: | ui.core | Version: | 1.8.11 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
The :tabbable selector is dependent on the :focusable selector. Both pull the tabindex attribute on each element they check. Some milliseconds can be shaved by reusing this value. It's a slight gain, but since :tabbable is run during Dialog initialization, complex dialogs can have real gains from this.
Attachments (0)
Change History (4)
Changed April 15, 2011 02:53PM UTC by comment:1
Changed April 29, 2011 12:24PM UTC by comment:2
| resolution: | → fixed |
|---|---|
| status: | new → closed |
Core: reuse tabindex value. Fixed #7257 - optimize :tabbable.
Changeset: fe3b36b8efcabf3d1f1d60523cae87c69a882f27
Changed May 02, 2011 12:37PM UTC by comment:3
Core: reuse tabindex value. Fixed #7257 - optimize :tabbable.
(cherry picked from commit fe3b36b8efcabf3d1f1d60523cae87c69a882f27)
Changeset: 96f6b1a7db1e3bc74de66153cf9be80152e04430
Changed July 30, 2011 11:50AM UTC by comment:4
This still performs very poorly (eg Firefox 5 on a new dialog with 300 elements takes around 5 seconds).
https://github.com/adambaratz/jquery-ui/commit/a847d8644a5102939e13133e5d8601e856d814a9