Ticket #7353 (closed feature: fixed)

Opened 2 years ago

Last modified 8 months ago

Effects unit tests

Reported by: gnarf Owned by: gnarf
Priority: blocker Milestone: 1.9.0
Component: ui.effects.core Version: 1.8.11
Keywords: Cc: gnarf
Blocking: Blocked by:

Description

We need to start adding unit tests for the effects code.

Change History

comment:1 Changed 2 years ago by gnarf

  • Owner set to gnarf
  • Status changed from new to assigned
  • Type changed from bug to enhancement

I have drafted the first set of tests I wanted to ensure - Queue ordering / hiding / showing functionality of $.effects.effect.*

 https://github.com/jquery/jquery-ui/pull/242

I still want to add some unit tests for some of the functionality in effects.core as well.

comment:2 Changed 2 years ago by gnarf

  • Priority changed from minor to critical

comment:3 Changed 13 months ago by scott.gonzalez

  • Milestone changed from 1.9 to 1.next

Effects cleanup is pushed to 1.10.

comment:4 Changed 13 months ago by scott.gonzalez

  • Priority changed from critical to blocker

comment:5 Changed 12 months ago by scott.gonzalez

  • Type changed from enhancement to feature

comment:6 Changed 9 months ago by scott.gonzalez

  • Milestone changed from 1.next to 1.10.0

comment:7 Changed 8 months ago by mikesherov

  • Cc gnarf added

gnarf, is this done now?

comment:8 Changed 8 months ago by gnarf

  • Status changed from assigned to closed
  • Resolution set to fixed

Done enough, I still want more tests eventually but I can't think of anything at the moment

comment:9 Changed 8 months ago by scott.gonzalez

  • Milestone changed from 1.10.0 to 1.9.0
Note: See TracTickets for help on using tickets.