Skip to main content

Search and Top Navigation

#7791 closed feature (patcheswelcome)

Opened October 13, 2011 07:05PM UTC

Closed August 20, 2014 01:17PM UTC

Accordion Tabindex should be customizable

Reported by: HankS Owned by:
Priority: minor Milestone: none
Component: [meta] ui.a11y Version: 1.8.16
Keywords: Cc:
Blocked by: Blocking:
Description

The accordion's keyboard support could be further improved by having a way to specify the tabindex to use. The current default of tabindex="0" prevents the accordion from being inserted in the middle of the overall tab flow.

Suggestions: add an option to specify the tabindex during accordion creation, an option to disable tabindex changes altogether (letting the developer handle them), or simply restore the tabindex originally specified in the markup by keeping a copy before changing to -1.

(Note: Trying to force a proper tabindex by changing it after accordion creation, or during the accordion's "change" event, doesn't work because the tabindex's are also reset to 0's and -1's when the keyboard up/down keys are pressed.)

Attachments (0)
Change History (9)

Changed October 21, 2011 07:55AM UTC by jzaefferer comment:1

This isn't restricted to Accordion - we're even building a bunch of new widgets where tabindex defaults to 0. Do we want to support custom tabindex everywhere?

Changed November 03, 2011 12:27PM UTC by scottgonzalez comment:2

component: ui.accordion[meta] ui.a11y

Changed February 27, 2012 03:51PM UTC by jzaefferer comment:3

Scott, any thoughts on this? Should be addressed while you're working on Accordion anyway.

Changed June 26, 2012 01:22AM UTC by scottgonzalez comment:4

type: enhancementfeature

Changed October 11, 2012 02:40PM UTC by scottgonzalez comment:5

milestone: 1.9.01.10.0

Changed October 28, 2012 08:27PM UTC by mikesherov comment:6

scott_gonzalez, can you mark this as open if it's a feature we're going to be implementing one day, or close as wontfix if not? Thanks!

Changed October 29, 2012 12:40AM UTC by scottgonzalez comment:7

status: newopen

Customized tab index is such a hassle, but for single focus widgets I think it's possible to handle. I don't think this is common enough to warrant an option, but I'd be ok with refactoring the code to make it possible to implement an extension.

Changed January 25, 2013 09:23PM UTC by tj.vantoll comment:8

milestone: 1.10.0none

Changed August 20, 2014 01:17PM UTC by scottgonzalez comment:9

resolution: → patcheswelcome
status: openclosed

I'm willing to accept PRs that add extension points to make this possible, but I don't think this is something we're going to address on our own.