Ticket #7810 (closed bug: fixed)

Opened 19 months ago

Last modified 15 months ago

Consistent naming convention for .data() keys

Reported by: scott.gonzalez Owned by: joern.zaefferer
Priority: blocker Milestone: 1.9.0
Component: [meta] ui.dev Version: 1.8.16
Keywords: Cc:
Blocking: Blocked by:

Description

There's a lot of variation in naming conventions for data stored on elements. We should formalize a naming convention and use it everywhere.

Change History

comment:1 Changed 19 months ago by scott.gonzalez

  • Priority changed from minor to blocker
  • Status changed from new to open

comment:2 Changed 15 months ago by joern.zaefferer

  • Owner set to joern.zaefferer
  • Status changed from open to assigned

Started this in the data-naming branch.

comment:3 Changed 15 months ago by joern.zaefferer

 https://github.com/jquery/jquery-ui/pull/607 addresses a good chunk of this.

Remaining: Widget, interactions and datepicker.

Widget currently sets data based on the widget's name. Changing that needs a BC layer.

Interactions rely a lot on other interactions, accessing them via data attributes. Haven't yet looked in detail if those are problematic.

Datepicker's usage is very similar to wiget. Looks like it just sets a datepicker property, nothing else.

comment:4 Changed 15 months ago by joern.zaefferer

  • Status changed from assigned to closed
  • Resolution set to fixed

We'll ignore datepicker and interactions for now, as those are being rewritten. Everything else is addressed.

Note: See TracTickets for help on using tickets.